Bug 442258 - Solid::NetworkShare does not know SMB3 filesystem
Summary: Solid::NetworkShare does not know SMB3 filesystem
Status: RESOLVED FIXED
Alias: None
Product: frameworks-solid
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.85.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-10 13:24 UTC by Alexander Reinholdt
Modified: 2022-08-24 10:36 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.98
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Reinholdt 2021-09-10 13:24:36 UTC
SUMMARY

Solid::NetworkShare does not know the network filesystem SMB3 and, thus, mounts with that filesystem are not detected on the system.

STEPS TO REPRODUCE

1. Connect a slot to the deviceAdded() signal of Solid::DeviceNotifier::instance().

2. Add the following if statement to the slot: 

if (device.isDeviceInterface(Solid::DeviceInterface::NetworkShare)) {
    qDebug() << "success";
} else {
    qDebug() << "failure";
}

3. Mount a Samba share with the SMB3 filesystem:

$ mount.smb3 //server/share /mount/point

OBSERVED RESULT

The output will always be "failure", even when a share with an SMB3 filesystem
is mounted.

EXPECTED RESULT

The output is "success" when a share with SMB3 filesystem is mounted and 
"failure" otherwise.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2
Kernel Version: 5.13.13-1-MANJARO (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 Alexander Reinholdt 2021-09-10 13:26:54 UTC
In addition: The output will be "success", when you mount the share with one of the defined filesystems (NFS and CIFS).
Comment 2 Harald Sitter 2021-09-13 12:19:33 UTC
From looking at the code I guess it needs adding to the list of NetworkShare mount types in FstabDevice and supposedly also adding to _k_isFstabNetworkFileSystem.
Comment 3 Bug Janitor Service 2022-08-07 14:16:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/solid/-/merge_requests/100