SUMMARY Ran with kdesrc-build konsole && kdesrc-run konsole No bug if there are multiple splits or multiple tabs in the previous window. STEPS TO REPRODUCE 1. Open a second window 2. Create a split-view in second window 3. Drag and drop one view to first window 4. Close the dropped view (by any means: headerbar button, ctl-shift-w, ctl-d, 'exit') OBSERVED RESULT Also closes the window the view was dragged from. EXPECTED RESULT Only close the focused view. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
Also, not present on 21.08.1
yep thanks confirmed on master - I'll have to check 21.08
I see the same issue on the 21.08 branch. Are you sure you don't see it there?
Not on 21.08.1 Manjaro...
I was able trace it to this commit on 21.08 branch https://invent.kde.org/utilities/konsole/-/commit/58d526f83b924732b8c82306fcc177f0bbe63295 AFAICT the issue is that both ViewManagers are hanging onto the session after a dnd, so that commit is just causing both to hit empty() in sessionFinished (kind of expected I think, but I was able to verify it). I can see how ViewManager disconnects from sessions when *detaching* a view or tab, but I don't see how they are supposed to be released after drag-and-drop. Both the ViewSplitter and SessionController from the source window get deleted, so maybe there's a missing connection to one of those signals?
Added a commit to MR 480
Git commit 29977a23645e2401f9e108f06692176c7d7f8366 by Tomaz Canabrava, on behalf of Nathan Sprangers. Committed on 15/11/2021 at 14:02. Pushed by tcanabrava into branch 'master'. Disconnect view/session after drag-and-drop Adds a missing signal/slot connection for when a split-view is drag-and- dropped to a new window. Use an existing method to handle it the same way as drag-and-dropping or detaching a tab. M +12 -5 src/ViewManager.cpp M +7 -0 src/ViewManager.h M +5 -0 src/session/SessionController.h M +1 -1 src/widgets/ViewContainer.cpp https://invent.kde.org/utilities/konsole/commit/29977a23645e2401f9e108f06692176c7d7f8366