Created attachment 141390 [details] Screenshot SUMMARY The sort menu dropdowns at the "Recently Played" and "Frequently Played" views have no labels next to the menu item checkboxes. Only these two views are affected, the other views with sorting support doesn't have this issue ("Albums", "Artists", "Tracks", "Genres", "Files"). Thankfully sorting still works at those views regardless the missing labels. SOFTWARE/OS VERSIONS Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.3
Also just noticed the checkboxes in those dropdowns are also wrong, they should have been radio buttons. Sorting orders are mutually exclusive options. Should I file a separate ticket for this?
lol that's true. Yes, separate ticket for radio buttons would be nice.
Radio button ticket: Bug 442234
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/406
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/407
Git commit f449f49aca4188f09dbb3d9aab69e97783ddcee3 by Nate Graham, on behalf of Jack Hill. Committed on 10/01/2023 at 22:09. Pushed by ngraham into branch 'master'. Fix Recently and Frequently Played sort buttons The sortRole for both views were being changed to TitleRole, since each view is track-based (i.e. they display tracks, as opposed to albums, artists, etc.). I think the function responsible for this exists for future purposes when users will be able to switch between grid/list views manually. Solution to is to just hardcode the sortRole and sortOrder of each view. This also fixes the problem where the sort menu had no text. Note that the sorting for "Frequently Played" currently does sort purely based on each tracks' play count. This will be addressed elsewhere. FIXED-IN: 21.12.2 M +25 -6 src/viewmanager.cpp M +2 -2 src/viewmanager.h https://invent.kde.org/multimedia/elisa/commit/f449f49aca4188f09dbb3d9aab69e97783ddcee3
Git commit f47edcc1bf4a0483a679f58595a71814b6b19182 by Nate Graham, on behalf of Jack Hill. Committed on 11/01/2023 at 22:41. Pushed by ngraham into branch 'release/21.12'. Fix Recently and Frequently Played sort buttons The sortRole for both views were being changed to TitleRole, since each view is track-based (i.e. they display tracks, as opposed to albums, artists, etc.). I think the function responsible for this exists for future purposes when users will be able to switch between grid/list views manually. Solution to is to just hardcode the sortRole and sortOrder of each view. This also fixes the problem where the sort menu had no text. Note that the sorting for "Frequently Played" currently does sort purely based on each tracks' play count. This will be addressed elsewhere. FIXED-IN: 21.12.2 (cherry picked from commit f449f49aca4188f09dbb3d9aab69e97783ddcee3) M +25 -6 src/viewmanager.cpp M +2 -2 src/viewmanager.h https://invent.kde.org/multimedia/elisa/commit/f47edcc1bf4a0483a679f58595a71814b6b19182
Git commit 1f5b57e8e1c3019c4ab00d6d1eba5ddd6b3feb8b by Nate Graham, on behalf of Jack Hill. Committed on 12/01/2023 at 21:01. Pushed by ngraham into branch 'release/22.12'. Fix Recently and Frequently Played sort buttons The sortRole for both views were being changed to TitleRole, since each view is track-based (i.e. they display tracks, as opposed to albums, artists, etc.). I think the function responsible for this exists for future purposes when users will be able to switch between grid/list views manually. Solution to is to just hardcode the sortRole and sortOrder of each view. This also fixes the problem where the sort menu had no text. Note that the sorting for "Frequently Played" currently does sort purely based on each tracks' play count. This will be addressed elsewhere. FIXED-IN: 21.12.2 (cherry picked from commit f449f49aca4188f09dbb3d9aab69e97783ddcee3) M +25 -6 src/viewmanager.cpp M +2 -2 src/viewmanager.h https://invent.kde.org/multimedia/elisa/commit/1f5b57e8e1c3019c4ab00d6d1eba5ddd6b3feb8b