Bug 442095 - process names indented too far in Tree View
Summary: process names indented too far in Tree View
Status: CONFIRMED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-06 21:02 UTC by d3coder
Modified: 2022-04-28 14:09 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/b623698fb9239c99421107609bb2f71deb24f509
Version Fixed In:
Sentry Crash Report:

Attachments
row process name rendering comparison (45.29 KB, image/png)
2021-09-06 21:02 UTC, d3coder 		Details
image with red lines showing excess distance (52.01 KB, image/png)
2021-09-08 20:53 UTC, d3coder 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description d3coder 2021-09-06 21:02:45 UTC 
Created attachment 141344 [details]
row process name rendering comparison

SUMMARY
While in tree view, process name renders too far away from row controls or 

STEPS TO REPRODUCE
1. Start KSysGuard and enable tree view
2. Start plasma-systemmonitor and enable tree view
3. Compare rows

OBSERVED RESULT
Process name rendered too far away from row controls or row ASCII

EXPECTED RESULT
Rows are rendered like in KSysGuard

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2
Kernel Version: 5.13.13-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600

ADDITIONAL INFORMATION
Comment 1 d3coder 2021-09-06 21:03:36 UTC 
Ah, also process owners are colored in KSysGuard.
Comment 2 Nate Graham 2021-09-08 20:49:03 UTC 
Can't you resize the name column to get the same appearance as in KSysGuard?
Comment 3 d3coder 2021-09-08 20:53:58 UTC 
Created attachment 141409 [details]
image with red lines showing excess distance

I meant this distance, marked it with red lines
Comment 4 Nate Graham 2021-09-08 21:02:06 UTC 
Oh! Can confirm.
Comment 5 Bug Janitor Service 2021-10-01 12:13:47 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/164
Comment 6 Nate Graham 2021-10-01 14:41:18 UTC 
Fixed by David Edmundson with https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/b623698fb9239c99421107609bb2f71deb24f509 in Plasma 5.23.
Comment 7 d3coder 2021-10-01 14:58:18 UTC 
I am not sure what has been fixed, but i guess this was some real bug.
I will open another related issue
Comment 8 Nate Graham 2021-10-01 14:59:05 UTC 
The bug you reported here is what's been fixed. :)
Comment 9 d3coder 2021-10-01 15:03:53 UTC 
I compiled from git and didn't saw any difference.
I opened new report because i thought this one fixed something different https://bugs.kde.org/show_bug.cgi?id=443201
Comment 10 Nate Graham 2021-10-01 15:05:37 UTC 
That's not how this works. :) If the originally reported issue here is not fixed with that change, then we re-open this bug; we don't open a new one.
Comment 11 Nate Graham 2021-10-01 15:06:44 UTC 
Can reproduce that the issue is not actually fixed with that commit, sadly. :(
Comment 12 Lemuel Simon 2022-02-27 22:40:19 UTC 
Hmm...I think this happens because an 'icon' is expected within that gap. Say, if look a program with an icon (Firefox, Kate,ect), the icon will fill the gap. However, most processes don't have one (systemd,KWin,plasmashell), and there isn't a 'fallback' or 'placeholder' icon for such processes in System Monitor. I suggest that the generic 'terminal/console' icon be used for that (if icons are enabled). I think it would appropriate since its 'command line' or background processes anyway. Thoughts?
Comment 13 David Redondo 2022-04-28 14:09:35 UTC 
> Thoughts?

Fully agree. Do you want to make a Merge Request?