Bug 442088 - Mixed Clips issues with keyboard editing
Summary: Mixed Clips issues with keyboard editing
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: 21.08.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-06 18:01 UTC by Anders Lund
Modified: 2024-01-16 20:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
fritzibaby: Brainstorm+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Lund 2021-09-06 18:01:26 UTC
SUMMARY
There are two issues:

1. Adding a mix with keyboard requires a clip to be selected, even if the playhead is at a clip meeting point. Isn't that a regression?

STEPS TO REPRODUCE
1. Have a timeline with two clips
2. Press Alt + arrow to go the the joint
3. Press U

OBSERVED RESULT
No mix applied. Kdenlive complains about missing selection

EXPECTED RESULT
Mix applied

2. Adding a mix with keyboard does not respect the track (de)activated state. Since all other keyboard editing does, it is unespected.

STEPS TO REPRODUCE
1. Have a timeline with two AV clips
2. Deactivate the audio track
3. Press Alt + arrow to go the the joint, + to select a clip
4. Press U

OBSERVED RESULT
Mix is applied to both video and audio track

EXPECTED RESULT
Mix applied ONLY to video track, because audio track is deactivated.



SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux, up to date 
(available in About System)
KDE Plasma Version: Current
KDE Frameworks Version: Current
Qt Version: Current KDE relatable

ADDITIONAL INFORMATION
Comment 1 emohr 2021-09-08 18:26:10 UTC
Thank you for reporting. 

To #1: after step 2 you have to press "+" to select a clip. 
To #2: At the moment it's only working if you lock the audio track.

The best way would be place the cursor on the cut and activate the track where you want to apply the transition. If you are not on a cut 2 transitions should be applied on both the extremities of the clip where the cursor is where we have an active track. This way everything becomes faster and more efficient.
Comment 2 Anders Lund 2021-09-09 08:56:53 UTC
Thank you for taking these up.
1: I'm aware of the shortcut to select a clip, I just believe this was not the case in earlier versions. And if doubleclicking does not require a selection, it would be logical if using U wouldn't eiter - esp with the playhead at clip joint position.

2: As for the activated state, the idea, iiutc, is that automated editing procedures will never be applied to deactivated tracks (bu always to active ones). So if applying a mix pr keyboard is an automated editing action, the ative state should be adhered. And as I said, as a user, I would expect that.

Another note about mixes: They are applied to grouped clips, but not othwervise respecting the grouping. So if I click on a mix, only either the mix in the video track OR the mix in the audio track is selected. Likewise when changing duration by dragging. I find that mildly confusing.
Comment 3 Bernd 2023-12-12 18:31:11 UTC
Deleting a mix is not possible: Using the DEL key throws an error message about the key being ambiguous even though it is not and the Configure Keyboard Shortcuts dialog window shows only one use of DEL; and using the right-click > Delete Selected Item does not work either because the right-click selects the clip with the mix and deleting the selected item deletes the mix and the clip.

This is for appimage version 23.08.4
Comment 4 Jean-Baptiste Mardelle 2023-12-13 08:05:16 UTC
Git commit ab2169122e150697bf07f9f41695310df685076b by Jean-Baptiste Mardelle.
Committed on 13/12/2023 at 09:05.
Pushed by mardelle into branch 'master'.

Allow adding a mix without selection

M  +12   -0    src/timeline2/view/timelinecontroller.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/ab2169122e150697bf07f9f41695310df685076b
Comment 5 Jean-Baptiste Mardelle 2023-12-13 11:43:20 UTC
Git commit 6f91539ab0e6c6699156dcd85e0349ea74d2bbe3 by Jean-Baptiste Mardelle.
Committed on 13/12/2023 at 12:43.
Pushed by mardelle into branch 'master'.

Don't add mixes to disabled tracks

M  +1    -1    src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/6f91539ab0e6c6699156dcd85e0349ea74d2bbe3
Comment 6 Jean-Baptiste Mardelle 2023-12-13 11:54:16 UTC
I fixed the 2 issues mentioned in the original report as I think it is what most users would expect. However I cannot reproduce the problem with the "Del" key to remove a Mix. Is it on Windows ? Can you share a screenshot of your Kdenlive window so I can check which widgets are displayed in case one of them is messing up the shortcuts handling?
Comment 7 Bernd 2023-12-13 15:41:22 UTC
(In reply to Jean-Baptiste Mardelle from comment #6)
> I fixed the 2 issues mentioned in the original report as I think it is what
> most users would expect. However I cannot reproduce the problem with the
> "Del" key to remove a Mix. Is it on Windows ? Can you share a screenshot of
> your Kdenlive window so I can check which widgets are displayed in case one
> of them is messing up the shortcuts handling?

I encountered it in Linux but cannot reproduce today when trying to create the screenshots you asked for. Beats me. But if it happens again I will create screenshots.

So, now that the DEL key works (again), could you check (and fix) the right-click and "Delete selected item" issue with Mixes? A right-click on a mix selects the clip instead, and a "Delete selected item" deletes the clip and the mix. This does not happen with a normal composition: a right-click only selects the composition.

BTW: I hope you are feeling better and are on the road for a speedy recovery
Comment 8 Jean-Baptiste Mardelle 2023-12-14 07:34:40 UTC
Git commit b1da177c002c5abfa3e096fef48b6306da996fa2 by Jean-Baptiste Mardelle.
Committed on 14/12/2023 at 08:34.
Pushed by mardelle into branch 'master'.

Right click on a mix now shows a mix menu (allowing deletion)

M  +13   -5    src/timeline2/view/qml/Clip.qml
M  +1    -0    src/timeline2/view/qml/timeline.qml
M  +11   -0    src/timeline2/view/timelinewidget.cpp
M  +2    -0    src/timeline2/view/timelinewidget.h

https://invent.kde.org/multimedia/kdenlive/-/commit/b1da177c002c5abfa3e096fef48b6306da996fa2
Comment 9 Jean-Baptiste Mardelle 2024-01-16 20:46:26 UTC
Git commit 5f50241808dd219fe4594b5fc318fc35db5df0d0 by Jean-Baptiste Mardelle.
Committed on 16/01/2024 at 15:28.
Pushed by mardelle into branch 'release/23.08'.

Don't add mixes to disabled tracks

M  +1    -1    src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/5f50241808dd219fe4594b5fc318fc35db5df0d0
Comment 10 Jean-Baptiste Mardelle 2024-01-16 20:46:27 UTC
Git commit 2a4c4a18273415946ada131a4c5df4beaf40e29c by Jean-Baptiste Mardelle.
Committed on 16/01/2024 at 15:28.
Pushed by mardelle into branch 'release/23.08'.

Allow adding a mix without selection

M  +12   -0    src/timeline2/view/timelinecontroller.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/2a4c4a18273415946ada131a4c5df4beaf40e29c
Comment 11 Jean-Baptiste Mardelle 2024-01-16 20:46:29 UTC
Git commit 24bf262749b27c6861f822abdba3903a0edce234 by Jean-Baptiste Mardelle.
Committed on 16/01/2024 at 15:38.
Pushed by mardelle into branch 'release/23.08'.

Right click on a mix now shows a mix menu (allowing deletion)

M  +14   -5    src/timeline2/view/qml/Clip.qml
M  +1    -0    src/timeline2/view/qml/timeline.qml
M  +11   -0    src/timeline2/view/timelinewidget.cpp
M  +2    -0    src/timeline2/view/timelinewidget.h

https://invent.kde.org/multimedia/kdenlive/-/commit/24bf262749b27c6861f822abdba3903a0edce234