Bug 442007 - Decoding table tool doesn't save preferences upon exit
Summary: Decoding table tool doesn't save preferences upon exit
Status: RESOLVED FIXED
Alias: None
Product: okteta
Classification: Applications
Component: general (show other bugs)
Version: 0.26.6
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Friedrich W. H. Kossebau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-04 18:10 UTC by viktor
Modified: 2022-02-21 22:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.26.7
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description viktor 2021-09-04 18:10:47 UTC
SUMMARY
I'm using decoding table quite a lot and there is one annoying thing (may be it's not a bug) - settings (endianness and "Unsigned as hexadecimal") are not saved when closing Okteta. The tool itself will be shown (if left visible upon exit), but its settings will not be restored - instead, default little endianness and Unsigneds as hex will be used.

STEPS TO REPRODUCE
1. Open Okteta, enable Decoding table tool
2. Set desired endianness and (optionally) display of unsigneds as hex
3. Close Okteta
4. Run it again and check settings of Decoding table tool

OBSERVED RESULT
Settings of the Decoding tool are reset to defaults (little endianness, display unsigneds as hex)

EXPECTED RESULT
Settings of the Decoding tool will be preserved

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2 with KDE patches
Comment 1 Friedrich W. H. Kossebau 2022-02-21 22:33:49 UTC
Git commit 6f7c81258b0bda11bdc99fabce22430c82dd7069 by Friedrich W. H. Kossebau.
Committed on 21/02/2022 at 19:33.
Pushed by kossebau into branch '0.26'.

Tools: store used settings in the config
FIXED-IN: 0.26.7

M  +21   -2    kasten/controllers/view/bytetable/bytetableview.cpp
M  +1    -0    kasten/controllers/view/bytetable/bytetableview.hpp
M  +99   -2    kasten/controllers/view/charsetconversion/charsetconversiontool.cpp
M  +40   -1    kasten/controllers/view/checksum/checksumtool.cpp
M  +1    -0    kasten/controllers/view/checksum/checksumtool.hpp
M  +28   -16   kasten/controllers/view/checksum/checksumview.cpp
M  +2    -1    kasten/controllers/view/checksum/checksumview.hpp
M  +52   -2    kasten/controllers/view/filter/filtertool.cpp
M  +11   -1    kasten/controllers/view/filter/filtertool.hpp
M  +29   -5    kasten/controllers/view/filter/filterview.cpp
M  +2    -0    kasten/controllers/view/filter/filterview.hpp
M  +22   -7    kasten/controllers/view/libbytearraychecksum/abstractbytearraychecksumalgorithm.cpp
M  +6    -2    kasten/controllers/view/libbytearraychecksum/abstractbytearraychecksumalgorithm.hpp
M  +3    -1    kasten/controllers/view/libbytearraychecksum/algorithm/adler32bytearraychecksumalgorithm.cpp
M  +3    -1    kasten/controllers/view/libbytearraychecksum/algorithm/crc32bytearraychecksumalgorithm.cpp
M  +21   -1    kasten/controllers/view/libbytearraychecksum/algorithm/crc64bytearraychecksumalgorithm.cpp
M  +2    -0    kasten/controllers/view/libbytearraychecksum/algorithm/crc64bytearraychecksumalgorithm.hpp
M  +38   -0    kasten/controllers/view/libbytearraychecksum/algorithm/crc64bytearraychecksumparameterset.cpp
M  +6    -0    kasten/controllers/view/libbytearraychecksum/algorithm/crc64bytearraychecksumparameterset.hpp
M  +21   -2    kasten/controllers/view/libbytearraychecksum/algorithm/modsum16bytearraychecksumalgorithm.cpp
M  +2    -0    kasten/controllers/view/libbytearraychecksum/algorithm/modsum16bytearraychecksumalgorithm.hpp
M  +21   -2    kasten/controllers/view/libbytearraychecksum/algorithm/modsum32bytearraychecksumalgorithm.cpp
M  +2    -0    kasten/controllers/view/libbytearraychecksum/algorithm/modsum32bytearraychecksumalgorithm.hpp
M  +21   -2    kasten/controllers/view/libbytearraychecksum/algorithm/modsum64bytearraychecksumalgorithm.cpp
M  +2    -0    kasten/controllers/view/libbytearraychecksum/algorithm/modsum64bytearraychecksumalgorithm.hpp
M  +3    -1    kasten/controllers/view/libbytearraychecksum/algorithm/modsum8bytearraychecksumalgorithm.cpp
M  +38   -1    kasten/controllers/view/libbytearraychecksum/algorithm/modsumbytearraychecksumparameterset.cpp
M  +6    -0    kasten/controllers/view/libbytearraychecksum/algorithm/modsumbytearraychecksumparameterset.hpp
M  +2    -2    kasten/controllers/view/libbytearraychecksum/algorithm/qca2bytearraychecksumalgorithm.cpp
M  +1    -1    kasten/controllers/view/libbytearraychecksum/algorithm/qca2bytearraychecksumalgorithm.hpp
M  +3    -1    kasten/controllers/view/libbytearraychecksum/algorithm/template/template_bytearraychecksumalgorithm.cpp
M  +24   -13   kasten/controllers/view/libbytearraychecksum/bytearraychecksumalgorithmfactory.cpp
M  +22   -7    kasten/controllers/view/libbytearrayfilter/abstractbytearrayfilter.cpp
M  +6    -2    kasten/controllers/view/libbytearrayfilter/abstractbytearrayfilter.hpp
M  +1    -0    kasten/controllers/view/libbytearrayfilter/abstractbytearrayfilterparametersetedit.hpp
M  +21   -2    kasten/controllers/view/libbytearrayfilter/filter/andbytearrayfilter.cpp
M  +2    -0    kasten/controllers/view/libbytearrayfilter/filter/andbytearrayfilter.hpp
M  +3    -1    kasten/controllers/view/libbytearrayfilter/filter/invertbytearrayfilter.cpp
M  +75   -3    kasten/controllers/view/libbytearrayfilter/filter/operandbytearrayfilterparameterset.cpp
M  +23   -3    kasten/controllers/view/libbytearrayfilter/filter/operandbytearrayfilterparameterset.hpp
M  +10   -3    kasten/controllers/view/libbytearrayfilter/filter/operandbytearrayfilterparametersetedit.cpp
M  +21   -2    kasten/controllers/view/libbytearrayfilter/filter/orbytearrayfilter.cpp
M  +2    -0    kasten/controllers/view/libbytearrayfilter/filter/orbytearrayfilter.hpp
M  +22   -2    kasten/controllers/view/libbytearrayfilter/filter/reversebytearrayfilter.cpp
M  +2    -0    kasten/controllers/view/libbytearrayfilter/filter/reversebytearrayfilter.hpp
M  +18   -1    kasten/controllers/view/libbytearrayfilter/filter/reversebytearrayfilterparameterset.cpp
M  +6    -0    kasten/controllers/view/libbytearrayfilter/filter/reversebytearrayfilterparameterset.hpp
M  +2    -0    kasten/controllers/view/libbytearrayfilter/filter/reversebytearrayfilterparametersetedit.cpp
M  +21   -2    kasten/controllers/view/libbytearrayfilter/filter/rotatebytearrayfilter.cpp
M  +2    -0    kasten/controllers/view/libbytearrayfilter/filter/rotatebytearrayfilter.hpp
M  +22   -1    kasten/controllers/view/libbytearrayfilter/filter/rotatebytearrayfilterparameterset.cpp
M  +6    -0    kasten/controllers/view/libbytearrayfilter/filter/rotatebytearrayfilterparameterset.hpp
M  +5    -1    kasten/controllers/view/libbytearrayfilter/filter/rotatebytearrayfilterparametersetedit.cpp
M  +21   -2    kasten/controllers/view/libbytearrayfilter/filter/shiftbytearrayfilter.cpp
M  +2    -0    kasten/controllers/view/libbytearrayfilter/filter/shiftbytearrayfilter.hpp
M  +4    -1    kasten/controllers/view/libbytearrayfilter/filter/template/template_bytearrayfilter.cpp
M  +21   -2    kasten/controllers/view/libbytearrayfilter/filter/xorbytearrayfilter.cpp
M  +2    -0    kasten/controllers/view/libbytearrayfilter/filter/xorbytearrayfilter.hpp
M  +49   -4    kasten/controllers/view/poddecoder/poddecodertool.cpp
M  +18   -2    kasten/controllers/view/stringsextract/stringsextracttool.cpp

https://invent.kde.org/utilities/okteta/commit/6f7c81258b0bda11bdc99fabce22430c82dd7069