Bug 441952 - Cannot create a gocryptfs vault due to faulty version number checking code
Summary: Cannot create a gocryptfs vault due to faulty version number checking code
Status: RESOLVED FIXED
Alias: None
Product: Plasma Vault
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: HI normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-03 16:07 UTC by saedlar93
Modified: 2021-09-26 04:19 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-vault/-/commit/83b045afbd5d9db65411447060b448567d1ad7aa
Version Fixed In: 5.23
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description saedlar93 2021-09-03 16:07:37 UTC 
It seems like gocryptfs doesn't follow the standard *.*.* versioning assumed in plasma-vault code https://invent.kde.org/plasma/plasma-vault/-/blob/master/kded/engine/fusebackend_p.cpp#L160 which prevents the creation of gocryptfs vaults. 

"gocryptfs --version" output: "gocryptfs v2.1; go-fuse [vendored]; 2021-08-18 go1.17 linux/amd64"


SOFTWARE/OS VERSIONS
Operating System: EndeavourOS
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-09-09 16:34:31 UTC 
Confirmed. I thought I recalled someone submitting a merge request to fix this, but now I can't find it...
Comment 2 Nowshed H. Imran 2021-09-09 17:26:31 UTC 
I was about to file the same bug. Cryfs and encfs works but not gocryptfs.
Comment 3 Fabian Vogt 2021-09-09 18:13:15 UTC 
(In reply to Nate Graham from comment #1)
> Confirmed. I thought I recalled someone submitting a merge request to fix
> this, but now I can't find it...

Just this in IRC on 2021-08-19:

19:12 < fvogt> LiveLM[m]: and gocryptfs --version?
19:13 < LiveLM[m]> `gocryptfs v2.1; go-fuse [vendored]; 2021-08-18 go1.17 linux/amd64`
19:13 < fvogt> That's probably it
19:14 < fvogt> It expects a x.x.x version
19:14 < fvogt> So 2.1 doesn't  match
19:14 < tomz[m]> heh, thats just gotten a new release.... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/39e3097bc221fd4fb8325d702ed7f47ea8ed9d3a)
19:15 < tomz[m]> fvogt: sounds like a silly bug :-)
19:17 < fvogt> The version check code of plasma-vault has always been rather fragile
19:17 < fvogt> It's overly generic
19:18 < LiveLM[m]> > <@tomz:matrix.org> heh, thats just gotten a new release.... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/8eabccdb9c037ad2e194ce9db928eef19f15b21a)
19:19 < fvogt> You're just part of the QA team ;-)
19:21 < NateGraham[m]> Sounds like you found out why they call it the "bleeding edge!" 😆
19:33 < LiveLM[m]> 🤣
19:33 < LiveLM[m]> Anyways, thanks for the help guys!
19:33 < LiveLM[m]> Much appreciated
19:34 < NateGraham[m]> anyone wanna fix the bug in vaults?

And then silence...
Comment 4 Nate Graham 2021-09-09 18:25:22 UTC 
Urgh
Comment 5 Ivan Čukić 2021-09-09 18:31:45 UTC 
This is the reason I didn't want to support gocryptfs at first, as it didn't have the --version standardized (depends on how it was compiled, it could even be empty). 

When we got the patch for adding gocryptfs to Vault, I was told this has been fixed in gocryptfs since then.

I'll fix this, but I expect it to break again at some point...
Comment 6 Ivan Čukić 2021-09-09 22:21:42 UTC 
Should be fixed by https://invent.kde.org/plasma/plasma-vault/-/merge_requests/16 -- for 5.23
Comment 7 Nowshed H. Imran 2021-09-10 15:42:59 UTC 
Should I create a bug report in gocryptfs?
Comment 8 Ivan Čukić 2021-09-10 17:56:43 UTC 
No need. If this happens again, then I'll annoy them ;) Thanks
Comment 9 Nowshed H. Imran 2021-09-10 19:23:53 UTC 
Great!
Comment 10 Nowshed H. Imran 2021-09-26 04:19:11 UTC 
Gocryptfs has started using the version system recommended by Go. It has been implemented from version 2.2.0

https://github.com/rfjakob/gocryptfs#changelog