Bug 441824 - Share tab of file properties shows never-ending oversized loading animation
Summary: Share tab of file properties shows never-ending oversized loading animation
Status: RESOLVED DOWNSTREAM
Alias: None
Product: kdenetwork-filesharing
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-31 17:53 UTC by ratijas
Modified: 2021-09-05 19:58 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
desktop share tab goes round-and-round-and-round-around (1.10 MB, video/mp4)
2021-08-31 17:53 UTC, ratijas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ratijas 2021-08-31 17:53:14 UTC
Created attachment 141193 [details]
desktop share tab goes round-and-round-and-round-around

SUMMARY
Dolphin properties's Share tab goes round-and-round-and-round-around… Maybe I'm missing some plugin of package on my system? For example, I don't see any "samba" things installed.

STEPS TO REPRODUCE
1. Open some file/directory's info in Dolphin. Also works with other K-apps, like *.desktop file info from autostart KCM in system settings
2. Switch to Share tab.
3. Hypnotize yourself.

OBSERVED RESULT
Huge KDE spinner/ loader / busy indicator, never-ending animation, no errors reported.

EXPECTED RESULT
Modestly-sized busy indicator, proper errors if something is wrong.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2
Kernel Version: 5.13.12-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 15.6 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2

ADDITIONAL INFORMATION
I've never used file sharing on this system yet, so I can't say if it ever worked. I don't have any packages with "samba" in their name installed.
Comment 1 Harald Sitter 2021-09-01 14:05:36 UTC
File a bug with your distro. They are probably not installing the necessary runtime deps.
Comment 2 ratijas 2021-09-01 14:07:51 UTC
Wait a second, what if I don't want or need any of those file sharing tools? This isn't how KDE should handle missing optional features.
Comment 3 Harald Sitter 2021-09-02 11:28:35 UTC
(In reply to ratijas from comment #2)
> Wait a second, what if I don't want or need any of those file sharing tools?
> This isn't how KDE should handle missing optional features.

Then don't install kdenetwork-filesharing.
Comment 4 ratijas 2021-09-02 11:43:18 UTC
> Then don't install kdenetwork-filesharing.

Technically that might make sense. But as a "user" I have no idea what is that. 🙈

This isn't what we want our users to see even if they somehow got partial install for some reason.
Comment 5 Harald Sitter 2021-09-02 12:13:26 UTC
(In reply to ratijas from comment #4)
> > Then don't install kdenetwork-filesharing.
> 
> Technically that might make sense. But as a "user" I have no idea what is
> that. 🙈
> 
> This isn't what we want our users to see even if they somehow got partial
> install for some reason.

Which is why I said that you should report this to your distro. We do properly codify the requirements on a cmake level, if distros don't carry that through to their packaging then that's a bug in the distro.
Comment 6 ratijas 2021-09-02 12:17:37 UTC
> Which is why I said that you should report this to your distro. We do properly codify the requirements on a cmake level, if distros don't carry that through to their packaging then that's a bug in the distro.

But can't we also replace that huge boii spinner with some sane error message as a workaround? I might look into it on weekends if we agree on it.
Comment 7 Harald Sitter 2021-09-02 12:40:04 UTC
(In reply to ratijas from comment #6)
> > Which is why I said that you should report this to your distro. We do properly codify the requirements on a cmake level, if distros don't carry that through to their packaging then that's a bug in the distro.
> 
> But can't we also replace that huge boii spinner with some sane error
> message as a workaround? I might look into it on weekends if we agree on it.

I'd rather not. The problem isn't the spinner, the problem is that the packaging is wrong.
Comment 8 ratijas 2021-09-02 21:53:08 UTC
Let's see. On Arch Linux, latest

pacman -Qi kdenetwork-filesharing

>   Name            : kdenetwork-filesharing
>   Version         : 21.08.0-1
>   Description     : Properties dialog plugin to share a directory with the local network
>   Architecture    : x86_64
>   URL             : https://apps.kde.org/kdenetwork_filesharing/
>   Licenses        : GPL  LGPL  FDL
>   Groups          : kde-applications  kde-network
>   Provides        : None
>   Depends On      : kdeclarative
>   Optional Deps   : samba: folder sharing
>   Required By     : kde-network-meta

https://archlinux.org/packages/extra/x86_64/kdenetwork-filesharing/

samba indeed is specified as optional and not installed on my local.

Let's peek at CMakeLists.txt:

>   find_package(net)
>   set_package_properties(net PROPERTIES
>       TYPE RUNTIME
>       DESCRIPTION "Samba CLI tool"
>       PURPOSE "Runtime dependency to do anything"
>   )

find_package() without REQUIRED keyword. Plus some magical PackageKitQt5, and a lot more code which I don't understand (and so probably didn't maintainers of Arch).

I don't know much about PackageKit, but isn't it a thing to present a sudo button "clikk herrre to instoll"?

On the other hand, Ubuntu strictly required `samba-common-bin` dependency package… https://ubuntu.pkgs.org/21.04/kubuntu-backports-arm64/kdenetwork-filesharing_21.08.0-0ubuntu1~ubuntu21.04~ppa1_arm64.deb.html
Comment 9 ratijas 2021-09-02 22:00:02 UTC
Filed a report at Arch Linux bug tracker:

https://bugs.archlinux.org/task/71995
Comment 10 ratijas 2021-09-05 19:58:13 UTC
Arch Linux maintainer Antonio Rojas repackaged kdenetwork-filesharing, making samba a hard required dependency instead of an optional one.

We still think that spinner should be somehow fixed. What if the package is installed, but application is broken? Or config is so messed up, that samba is failing to start? Either way, UI should somehow handle defective backend instead of displaying gibberish.