Bug 441706 - Single finger panning gesture stops when dragging quickly
Summary: Single finger panning gesture stops when dragging quickly
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-29 14:50 UTC by Alvin Wong
Modified: 2021-09-05 12:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Tablet log for single touch point panning where panning stopped mid-gesture (24.01 KB, text/plain)
2021-08-29 14:50 UTC, Alvin Wong
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alvin Wong 2021-08-29 14:50:24 UTC
Created attachment 141121 [details]
Tablet log for single touch point panning where panning stopped mid-gesture

SUMMARY

The single finger panning gesture stops mid-gesture if the movement is too quick.


STEPS TO REPRODUCE
1. Disable touch painting
2. Pan with single touch
3. Increase touch movement speed

OBSERVED RESULT
Gesture stops when touch point moves quick enough.

EXPECTED RESULT
Gesture shall not stop no matter how fast the gesture is.

SOFTWARE/OS VERSIONS
Windows: 10 20H1

ADDITIONAL INFORMATION
On Surface Pro 2017
Nightly 6ce9aadc4b
Comment 1 Bug Janitor Service 2021-09-01 12:54:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1029
Comment 2 Alvin Wong 2021-09-05 12:26:35 UTC
Git commit f6c204f5f93617610edf9716d4741de0bd25e6cc by Alvin Wong.
Committed on 05/09/2021 at 12:14.
Pushed by alvinwong into branch 'master'.

Fix touch pan gesture stopping when moving quickly

The code before this change ignores large movements to prevent canvas
from jumping at the end of a 3-finger gesture, which also blocks fast
panning. This removes the movement delta check in favour of checking the
number of touch points, so that fast movements will no longer interrupts
the pan gesture.

M  +19   -10   libs/ui/input/kis_pan_action.cpp

https://invent.kde.org/graphics/krita/commit/f6c204f5f93617610edf9716d4741de0bd25e6cc
Comment 3 Alvin Wong 2021-09-05 12:27:00 UTC
Git commit 93111de94474fbd94b4718737f02611eb8554054 by Alvin Wong.
Committed on 05/09/2021 at 12:26.
Pushed by alvinwong into branch 'krita/5.0'.

Fix touch pan gesture stopping when moving quickly

The code before this change ignores large movements to prevent canvas
from jumping at the end of a 3-finger gesture, which also blocks fast
panning. This removes the movement delta check in favour of checking the
number of touch points, so that fast movements will no longer interrupts
the pan gesture.


(cherry picked from commit f6c204f5f93617610edf9716d4741de0bd25e6cc)

M  +19   -10   libs/ui/input/kis_pan_action.cpp

https://invent.kde.org/graphics/krita/commit/93111de94474fbd94b4718737f02611eb8554054