Bug 441569 - Freehand Selection Tool produces severe artifacts when holding Ctrl to draw polygonal outline
Summary: Freehand Selection Tool produces severe artifacts when holding Ctrl to draw p...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (other bugs)
Version First Reported In: 5.0.0-beta1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-08-26 12:50 UTC by Tyson Tan
Modified: 2021-11-17 14:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Freehand Selection Tool produces severe artifacts when pressing Ctrl to draw polygonal outline (152.74 KB, image/png)
2021-08-26 12:50 UTC, Tyson Tan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2021-08-26 12:50:54 UTC
Created attachment 141063 [details]
Freehand Selection Tool produces severe artifacts when pressing Ctrl to draw polygonal outline

Freehand Selection Tool produces severe artifacts when pressing Ctrl to draw polygonal outline.

Steps to reproduce:
1) Freehand Selection Tool
2) Hold Ctrl + Click
3) Move cursor
4) Severe artifacts

Operating System: Arch Linux
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2
Kernel Version: 5.13.12-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 16 × Intel® Core™ i9-9900KF CPU @ 3.60GHz
Memory: 62.8 GiB of RAM
Graphics Processor: Radeon RX 590 Series

krita-5.0.0-beta1-8f23816-x86_64.appimage
Comment 1 Ahab Greybeard 2021-08-27 15:49:54 UTC
Testing on Windows 10:
4.4.5 does not have this problem.
4.4.7 onwards to 5.1.0-prealpha (git 6ce9aadc4b) all have this problem.

Setting to Confirmed.
Comment 2 Dmitry Kazakov 2021-11-13 14:44:15 UTC
Hi, Tyson!

The bug should now be fixed with this commit:
https://invent.kde.org/graphics/krita/-/commit/a82f01c700571b344e859f491d05df2a5f4a9fea

Could you please check if it is really fixed in this build (I've just triggered it, so please wait till it is completed):
https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/1445/
Comment 3 Tyson Tan 2021-11-14 02:31:10 UTC
Thanks Dmitry, although it still produces slight artifacts as the traces of the straight line, it's much less obvious now.
Comment 4 Bug Janitor Service 2021-11-14 04:39:14 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 5 Bug Janitor Service 2021-11-16 23:33:38 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1164
Comment 6 Dmitry Kazakov 2021-11-17 13:33:31 UTC
Git commit fe70e79d308a4b6ddf0afdd4de29042baa1c3168 by Dmitry Kazakov, on behalf of Reinold Rojas.
Committed on 17/11/2021 at 13:32.
Pushed by dkazakov into branch 'master'.

Fix artifacts in freehand selection tool in polygonal mode

M  +1    -1    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/graphics/krita/commit/fe70e79d308a4b6ddf0afdd4de29042baa1c3168
Comment 7 Tyson Tan 2021-11-17 13:54:22 UTC
Thank you Dmitry and Reinold! :D
Comment 8 Dmitry Kazakov 2021-11-17 14:01:50 UTC
Git commit 9e8c85c83136d20f6cf5d2a700c22a2c55b08d0a by Dmitry Kazakov, on behalf of Reinold Rojas.
Committed on 17/11/2021 at 13:47.
Pushed by dkazakov into branch 'krita/5.0'.

Fix artifacts in freehand selection tool in polygonal mode
(cherry picked from commit fe70e79d308a4b6ddf0afdd4de29042baa1c3168)

M  +1    -1    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/graphics/krita/commit/9e8c85c83136d20f6cf5d2a700c22a2c55b08d0a