Bug 441257 - Feature request: switch to disable video window
Summary: Feature request: switch to disable video window
Status: RESOLVED INTENTIONAL
Alias: None
Product: Haruna
Classification: Applications
Component: generic (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: george fb
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-20 17:32 UTC by Luigi Baldoni
Modified: 2023-03-11 14:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luigi Baldoni 2021-08-20 17:32:55 UTC
Perhaps for audio-only files?

Or at least allow to minimize the window so that the black rectangle is not visible.
Comment 1 Luigi Baldoni 2022-09-09 16:27:16 UTC
(In reply to Luigi Baldoni from comment #0)
> Perhaps for audio-only files?
> 
> Or at least allow to minimize the window so that the black rectangle is not
> visible.

I just wondered if setting a default image might be more feasible, like the icon for
the mimetype being played.
Comment 2 george fb 2022-09-09 16:35:37 UTC
If there's a folder or cover file in the same folder as the playing file it will be displayed.
Comment 3 Luigi Baldoni 2022-09-09 17:11:35 UTC
(In reply to george fb from comment #2)
> If there's a folder or cover file in the same folder as the playing file it
> will be displayed.

I'm asking about the cases in which there isn't.
Comment 4 george fb 2022-11-04 14:40:31 UTC
Git commit 091020d71e657ec6aa27d7187744986ec79291f1 by George Florea Bănuș.
Committed on 04/11/2022 at 14:40.
Pushed by georgefb into branch 'master'.

add option to set a default cover for music files

used only when there's no other image loaded

M  +4    -0    src/qml/MpvVideo.qml
M  +42   -0    src/qml/Settings/VideoSettings.qml
M  +4    -3    src/settings/videosettings.kcfg

https://invent.kde.org/multimedia/haruna/commit/091020d71e657ec6aa27d7187744986ec79291f1
Comment 5 Luigi Baldoni 2023-03-11 12:56:27 UTC
Sorry for the  very late reply, family problems.
Was this merged into stable?
Comment 6 george fb 2023-03-11 13:21:39 UTC
(In reply to Luigi Baldoni from comment #5)
> Was this merged into stable?

Not the original request.
What was added is a setting (in video settings) to add a fallback image to be used when mpv can't find a video track/cover image.
Comment 7 Luigi Baldoni 2023-03-11 13:55:30 UTC
(In reply to george fb from comment #6)
> (In reply to Luigi Baldoni from comment #5)
> > Was this merged into stable?
> 
> Not the original request.
> What was added is a setting (in video settings) to add a fallback image to
> be used when mpv can't find a video track/cover image.

Thanks. I just tried it and the image is loaded, but the setting does not appear to be saved.
Comment 8 george fb 2023-03-11 14:43:40 UTC
Can you check if it saves if you click on another field after changing?
Comment 9 Luigi Baldoni 2023-03-11 14:49:50 UTC
(In reply to george fb from comment #8)
> Can you check if it saves if you click on another field after changing?

It does, thanks,