Bug 441113 - Krita's settings get reset to default after running g'mic
Summary: Krita's settings get reset to default after running g'mic
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (show other bugs)
Version: unspecified
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-18 07:40 UTC by Halla Rempt
Modified: 2021-08-19 13:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2021-08-18 07:40:41 UTC
If you change a setting, like say autosave interval from 15 mins to 1 min, run a g'mic filter and then check again, it's reset to 15 mins. If you then restart krita, it's 1 min again.
Comment 1 amyspark 2021-08-18 12:33:36 UTC
I'm stumped with this one, GMic does not use anything besides QSettings. The only change I did was to make them use their own organization/domain and name.

I'm currently digging into the preferences backend and I see the changes committed to kritarc, so it's not us (and certainly not GMic) who is messing with KConfig's internals.
Comment 2 amyspark 2021-08-18 12:36:43 UTC
In fact, after changing Autosave interval to 30 min from 60, and then a GMic run, we have three different values.

- Krita System Information: 3600 (the value at launch time)
- Preferences: 300 (the default? I'm not sure where KConfig is picking it from)
- kritarc: 1800 (the changed value)
Comment 3 amyspark 2021-08-18 12:38:00 UTC
(In reply to amyspark from comment #2)
> In fact, after changing Autosave interval to 30 min from 60, and then a GMic
> run, we have three different values.
> 
> - Krita System Information: 3600 (the value at launch time)
> - Preferences: 300 (the default? I'm not sure where KConfig is picking it
> from)
> - kritarc: 1800 (the changed value)

Strike the first line, scrolling the dump log shows the changed value successfully. It seems to be a dialog preferences bug.
Comment 4 Halla Rempt 2021-08-18 12:59:39 UTC
The autosave interval is 15 minutes by default.
Comment 5 Ahab Greybeard 2021-08-18 21:32:20 UTC
I've seen the Theme change from my usual 'Krita neutral' to 'Krita dark' but not every time when I run G'Mic.
Comment 6 amyspark 2021-08-19 01:23:38 UTC
Ack. The changes in 2.9.8 upstream have been pretty invasive, I'll trace the dark mode calls before releasing the fix.
Comment 7 amyspark 2021-08-19 13:01:56 UTC
Git commit 090fbdca858d904113b5723c24fdf841111676d0 by L. E. Segovia.
Committed on 19/08/2021 at 12:49.
Pushed by lsegovia into branch 'master'.

GMic: update to 2.9.8 patch 1
Related: bug 441116

M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/090fbdca858d904113b5723c24fdf841111676d0
Comment 8 amyspark 2021-08-19 13:04:22 UTC
Git commit dd4495836419c27f5eeb0e07b601205a460c04d8 by L. E. Segovia.
Committed on 19/08/2021 at 13:03.
Pushed by lsegovia into branch 'krita/5.0'.

GMic: update to 2.9.8 patch 1
Related: bug 441116
(cherry picked from commit 090fbdca858d904113b5723c24fdf841111676d0)

M  +2    -2    3rdparty_plugins/ext_gmic/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/dd4495836419c27f5eeb0e07b601205a460c04d8