Bug 440793 - Valgrind ppc64/tests/Makefile.am fixups
Summary: Valgrind ppc64/tests/Makefile.am fixups
Status: CLOSED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Carl Love
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-09 15:09 UTC by Will Schmidt
Modified: 2021-10-01 21:14 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
proposed patch for none/tests/ppc64/Makefile.am (2.25 KB, patch)
2021-08-09 15:09 UTC, Will Schmidt 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Will Schmidt 2021-08-09 15:09:02 UTC 
Created attachment 140611 [details]
proposed patch for none/tests/ppc64/Makefile.am

SUMMARY

Correct some issues as reported with none/tests/ppc64/Makefile.am. 

In particular, 
  -The wrong mcpu string is used for BUILD_FLAGS_ISA_3_00
  -Indentation (tab/whitespace) glitch in EXTRA_DIST definition.
  -Move jm_insn_CFLAGS definition to be near other CFLAGS defines.

proposed patch attached.

STEPS TO REPRODUCE
1. build and run valgrind tests on a power9 target
2. observe tests being built with a mcpu=power9 cflags.
3. 

OBSERVED RESULT


EXPECTED RESULT
victory.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Carl Love 2021-10-01 21:13:51 UTC 
Issues were addressed in commit:

commit 81032a82f77fc7038d80621fefd75b5726760a60
Author: Carl Love <cel@us.ibm.com>
Date:   Fri Sep 10 16:20:10 2021 -0500

    Cleanup of none/tests/ppc64/Makefile.am
    
    Fixing indentation and move the jm_insns_CFLAGS next to the other CFLAGS
    definitions.
    
    No functional changes.