You probably miss a dependency. You need to run sh install.sh and provide full output in order to identify what is wrong. The output you provide is not from sh install.sh

Thanks for the quick response.  I found this issue.  I had to remove the following lines from CmakeLists.txt:


string(REPLACE "-Wall" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
string(REPLACE "-Wformat-security" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})

If you look at the log in my previous post, you'll see that the compiler is failing because "some warnings being treated as errors".  

This is causing the build to fail on Fedora.  If you can either fix the errors or remove the lines from CmakeLists.txt it would be much appreciated.  I also found this that explains the situation:  

https://fedoraproject.org/wiki/Format-Security-FAQ

The reason this issue didn't occur in the previous releases was that the above mentioned lines weren't included until release 0.10.

Sorry I want these lines. Latte builds fine on the rest distros so if Fedora does not want findna solution then Fedora packagers can just remove these lines to create a package for the distro. The mentioned lines do not influence Latte functionality at all.

(In reply to Michail Vourlakos from comment #3)
> Sorry I want these lines. Latte builds fine on the rest distros so if Fedora
> does not want findna solution then Fedora packagers can just remove these
> lines to create a package for the distro. The mentioned lines do not
> influence Latte functionality at all.

Sorry for reopening, but I found some more information...

I found that in Fedora it's tripping over -Werror=format-security

For some reason, when the other lines were added, it activated that error.
Since you want to keep those other lines in, would you consider adding:

string(REPLACE "-Werror=format-security" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})

Why it's not happening in other distros, don't know.  Perhaps it will when they upgrade to later versions, but adding the additional line shouldn't cause them any issues, if the string isn't found, it will just be ignored.

Other distros are already providing latest versions. You can leave it open and see how it goes. No idea when and if i will add it.

(In reply to Michail Vourlakos from comment #5)
> Other distros are already providing latest versions. You can leave it open
> and see how it goes. No idea when and if i will add it.

Thanks, I've also submitted a question within the project to see if someone can explain what exactly is happening and why.  I'll let you know when I get a response.  It could be that fedora is at a more recent version of the software and/or that the other distros just patched CMakeList.txt without letting you know.

An update, reading Fedora article then Fedora is pretty clear why it is adding that specific check. Its argument is pretty understandable. 

First of all removing the check that Fedora adds is not good practice that could make Latte banned from Fedora because is not following its rules. 

Secondly in order for Latte to be accepted in Fedora the only way is Latte to become compatible with this. Latte v0.10 is being developed for two years, these two years none came and reguested that compliance. Unfortunately making v0.10 compliant I have no idea how much work is needed and also if it is also possible to not break translations. 

To make things even more anxious, v0.10 is scheduled to stay around for many years around. I have no idea if I will ever release a v0.11 or if someone will step in to continue development.

Thanks again for your quick replies.  I don't believe anyone is talking about banning anything.  I counted 15 errors when the compile failed.  I'll see if I can figure out a way to get more information to narrow that down.  I'm still a bit confused about why removing those lines made the problem disappear in Fedora.  IMO, it shouldn't have.  Additionally, when this change was approved by Fedora, they said that other distributions had already implemented, and that was 7 years ago.  So if that is indeed the case then that to me would imply they are also bypassing the check.  I had asked the question in the maintainer forum, if I don't get an answer there I'll open a ticket with the build infrastructure team.  I'll let you know what I find.  Thanks again for your quick responses.  latte-dock is a great package and also thanks for the .10 update.  I'm running it now on my laptop and it's working with no issues!

I made a test. Please change the two lines you mentioned in CMakeLists file with:

#hide warnings
string(REPLACE "-Wall" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
string(REPLACE "-Wdeprecated-declarations" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
string(REPLACE "-Wreorder" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
string(REPLACE "-Wunused-variable" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
string(REPLACE "-Wunused-parameter" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})

#add format security check
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wformat -Werror=format-security")


1. I enforced the Fedora rule to check what errors are happening
2. Does it build in Fedora in that case?
3. In my system it with above changes it builds just fine. If it doesnt build in Fedora what warnings are considered errors and it is not built?

(In reply to Michail Vourlakos from comment #9)
> I made a test. Please change the two lines you mentioned in CMakeLists file
> with:
> 
> #hide warnings
> string(REPLACE "-Wall" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wdeprecated-declarations" "" CMAKE_CXX_FLAGS
> ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wreorder" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wunused-variable" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> string(REPLACE "-Wunused-parameter" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
> 
> #add format security check
> set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wformat -Werror=format-security")
> 
> 
> 1. I enforced the Fedora rule to check what errors are happening
> 2. Does it build in Fedora in that case?
> 3. In my system it with above changes it builds just fine. If it doesnt
> build in Fedora what warnings are considered errors and it is not built?

Yes, that builds fine!  Thanks for fixing!

I also ran with the trace option, the error is:

cc1plus: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]

so that seems to imply that the errors are from removing the -Wformat and Fedora adding the Werror=format-security.  Which would explain why when I also removing it via the string REPLACE gets around the issue.

Git commit a67e3c050f1bf79d6e9687cfd66c8733b3d4bdd0 by Michail Vourlakos.
Committed on 12/08/2021 at 05:04.
Pushed by mvourlakos into branch 'v0.10'.

fix build with Fedora requirements

--simplify warnings and add formalt security checks

M  +8    -1    CMakeLists.txt

https://invent.kde.org/plasma/latte-dock/commit/a67e3c050f1bf79d6e9687cfd66c8733b3d4bdd0

Git commit 66ddda956b299bfe8c6c001f15b0164980d70dad by Michail Vourlakos.
Committed on 12/08/2021 at 05:08.
Pushed by mvourlakos into branch 'master'.

fix build with Fedora requirements

--simplify warnings and add formalt security checks

M  +8    -1    CMakeLists.txt

https://invent.kde.org/plasma/latte-dock/commit/66ddda956b299bfe8c6c001f15b0164980d70dad