Bug 440650 - Some icons should be flipped in RTL mode
Summary: Some icons should be flipped in RTL mode
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-05 21:43 UTC by Omeritzics
Modified: 2021-12-12 23:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Omeritzics 2021-08-05 21:43:39 UTC
SUMMARY
The "enter" icon should be flipped in the RTL interface.

OBSERVED RESULT
The "enter" icon in the RTL interface is as the same as in the LTR interface.
(סיסמה <‏)

EXPECTED RESULT
The "enter" icon in the RTL interface should be flipped.
(סיסמה >‏)
Comment 1 Nate Graham 2021-08-06 14:16:10 UTC
Where specifically? This generally needs code in individual apps that are affected to actually do the switching between the two icons. We already do this in many places, but I'm not surprised that we may have missed a few. Can you list them?
Comment 2 Omeritzics 2021-08-07 21:19:33 UTC
(In reply to Nate Graham from comment #1)
> Where specifically? This generally needs code in individual apps that are
> affected to actually do the switching between the two icons. We already do
> this in many places, but I'm not surprised that we may have missed a few.
> Can you list them?

I'm sorry for the late respond and for not specifying in the beginning.
The icons which should be flipped are:
1. The "Next" and "Previous" icons at the screenshot gallery in Discover
2. The "Forward" and "Back" icons in Filelight
3. The half-star icon at the rating section in KNewStuff
4. The "Enter" icon in the lockscreen
5. The "Next" and "Previous" icon in Gwenview
6. For some applications, the button which shows the collapsed icons when the screen is too small, or the window is minimized - should be flipped.

I'll may list more applications in the future.
Comment 3 Nate Graham 2021-11-29 19:31:27 UTC
FWIW In the future please file individual bug reports for each thing that needs to be fixed.
Comment 4 Nate Graham 2021-11-29 21:31:36 UTC
Git commit 04c8bc41f8448ef0876da5bb06e80792cdd97b4d by Nate Graham.
Committed on 29/11/2021 at 21:30.
Pushed by ngraham into branch 'master'.

Use RTL half-star rating icon when in RTL mode

M  +1    -1    src/qtquick/qml/private/Rating.qml

https://invent.kde.org/frameworks/knewstuff/commit/04c8bc41f8448ef0876da5bb06e80792cdd97b4d
Comment 5 Nate Graham 2021-11-29 21:39:37 UTC
Git commit f748d5109178f9624dbcc65b2439b0c3f538dd2b by Nate Graham.
Committed on 29/11/2021 at 21:38.
Pushed by ngraham into branch 'master'.

Reverse screenshots arrows when in RTL mode

M  +4    -4    discover/qml/ApplicationScreenshots.qml

https://invent.kde.org/plasma/discover/commit/f748d5109178f9624dbcc65b2439b0c3f538dd2b
Comment 6 Nate Graham 2021-11-29 21:40:08 UTC
Git commit 704e826a3e7c0dc65f49accd2c8deaf22580be5d by Nate Graham.
Committed on 29/11/2021 at 21:39.
Pushed by ngraham into branch 'Plasma/5.23'.

Reverse screenshots arrows when in RTL mode

M  +4    -4    discover/qml/ApplicationScreenshots.qml

https://invent.kde.org/plasma/discover/commit/704e826a3e7c0dc65f49accd2c8deaf22580be5d
Comment 7 Nate Graham 2021-11-29 21:46:04 UTC
Git commit c007e68a3e8bb53f96e69fc950ac2359c29bf79f by Nate Graham.
Committed on 29/11/2021 at 21:45.
Pushed by ngraham into branch 'master'.

Lock & login screens: Use RTL-friendly arrows when in RTL mode

M  +1    -1    lookandfeel/contents/lockscreen/MainBlock.qml
M  +1    -1    sddm-theme/Login.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c007e68a3e8bb53f96e69fc950ac2359c29bf79f
Comment 8 Nate Graham 2021-11-29 21:46:27 UTC
Git commit a61e7db8bb9ebb7f802692cc59ed5ae38d1a06b2 by Nate Graham.
Committed on 29/11/2021 at 21:46.
Pushed by ngraham into branch 'Plasma/5.23'.

Lock & login screens: Use RTL-friendly arrows when in RTL mode
(cherry picked from commit c007e68a3e8bb53f96e69fc950ac2359c29bf79f)

M  +1    -1    lookandfeel/contents/lockscreen/MainBlock.qml
M  +1    -1    sddm-theme/Login.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a61e7db8bb9ebb7f802692cc59ed5ae38d1a06b2
Comment 9 Nate Graham 2021-11-29 21:47:28 UTC
Did all the QML stuff. Don't know how to do the QWidgets stuff (Filelight and Gwenview). I'll look into it later.
Comment 10 Nate Graham 2021-12-12 22:52:29 UTC
Git commit ee14ff733083ac720f8d064abe2a72d8846272a2 by Nate Graham.
Committed on 12/12/2021 at 22:51.
Pushed by ngraham into branch 'master'.

Reverse "next" and "previous" icons in RTL mode

M  +3    -2    src/historyAction.cpp

https://invent.kde.org/utilities/filelight/commit/ee14ff733083ac720f8d064abe2a72d8846272a2
Comment 11 Nate Graham 2021-12-12 23:00:45 UTC
Git commit c2e2c2ff1e53ff11d13f315f4f012f658ca9d037 by Nate Graham.
Committed on 12/12/2021 at 23:00.
Pushed by ngraham into branch 'master'.

Reverse "next" and "previous" icons in RTL mode

M  +2    -2    app/mainwindow.cpp
M  +5    -3    lib/datewidget.cpp

https://invent.kde.org/graphics/gwenview/commit/c2e2c2ff1e53ff11d13f315f4f012f658ca9d037
Comment 12 Nate Graham 2021-12-12 23:01:22 UTC
All are done now! In the future, please open a different bug report for each individual issue.