Bug 440604 - Close button for inline message can overlap right-most action button
Summary: Close button for inline message can overlap right-most action button
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.84.0
Platform: Other Linux
: NOR minor
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-04 19:52 UTC by postix
Modified: 2021-08-05 15:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.85
Sentry Crash Report:


Attachments
Screenshot (65.83 KB, image/png)
2021-08-04 19:52 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2021-08-04 19:52:42 UTC
Created attachment 140522 [details]
Screenshot

SUMMARY

Just a very minor aesthetically issue: If the window size of the Systemsettings is small enough, the button to open the "Display and Monitor" KCM lies directly under the close button of the inline message. In case on hovering on the close button, it's outlining covers the button below as seen in the screenshot.


STEPS TO REPRODUCE
1. Change display scaling to e. g. 200%
2. Go to fonts KCM
3. Click on reset the changes -- just changing it does not trigger the inline message :)
4. Activate the "force dpi" option

OBSERVED RESULT

The inline message appears with the minor issue.


EXPECTED RESULT

The inline message appears with the close button far enough away from the other button.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20210730
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.2
Kernel Version: 5.13.4-1-default (64-bit)
Graphics Platform: X11
Scaling: 200%
Comment 1 Nate Graham 2021-08-05 15:06:48 UTC
Can confirm when the previous font was 10pt Noto Sans. I didn't notice this because I use 11, and at 11pt, the problem does not manifest due to random chance.
Comment 2 Nate Graham 2021-08-05 15:25:41 UTC
Git commit 2545d84581e9cf35dddd4320288a66e8d2f9e33d by Nate Graham.
Committed on 05/08/2021 at 15:23.
Pushed by ngraham into branch 'master'.

[InlineMessage] Correct spacing between close button and action buttons

The Close button is a gridUnit in size, but ActionButtons was using
LargeSpacing as its height, causing the two to overlap with the default
font size of 10pt Noto Sans. Changing to GridUnit corrects the problem.
FIXED-IN: 5.85

M  +2    -2    src/controls/templates/InlineMessage.qml

https://invent.kde.org/frameworks/kirigami/commit/2545d84581e9cf35dddd4320288a66e8d2f9e33d