Bug 440492 - Enabling Reboot to UEFI shouldn't trigger "Unsaved changes" when closing the KCM
Summary: Enabling Reboot to UEFI shouldn't trigger "Unsaved changes" when closing the KCM
Status: CONFIRMED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_smserver (other bugs)
Version First Reported In: 6.0.4
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-01 12:56 UTC by Ilya Bizyaev
Modified: 2024-05-21 14:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Bizyaev 2021-08-01 12:56:44 UTC
STEPS TO REPRODUCE
1. Open the "Desktop Session" page in System Settings
2. Enable "Enter firmware setup screen on next restart", enter your password and confirm
3. Close the window

OBSERVED RESULT
System Settings warn about unsaved changes


EXPECTED RESULT
There are no configuration changes being made, nothing to save, and the checkbox remains ticked even if you "discard" the changes.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Leap 15.3
KDE Plasma Version: 5.22.4
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.2
Kernel Version: 5.3.18-59.16-default (64-bit)

ADDITIONAL INFORMATION
Works as expected if I launch the KCM with `kcmshell5 kcm_smserver` instead.
Comment 1 Nate Graham 2021-08-02 19:36:18 UTC
Confirmed. Manually adding `kcm.needsSave = false;` into the checkbox's onToggled: signal handles has no effect.
Comment 2 Nate Graham 2021-08-02 19:40:03 UTC
Basically the bug is that this one setting is using the Instant Apply paradigm, but the rest of the page uses the Explicit Apply paradigm and isn't aware that it shouldn't prompt to apply or discard for just this one checkbox.
Comment 3 Liz Lee 2024-05-21 14:32:55 UTC
The problem still persists.

When you check the "Enter UEFI setup screen"-checkbox, a banner with a "Restart Now" button appears on the top of the settings page, which is generally a good idea. The problem is, however, even when clicking this "Restart Now" button, the "Apply Settings"-prompt still appears.

I have a better solution for the whole situation:

Just make a "Restart now and enter the UEFI screen" button next to the checkbox always visible (i.e. the button should be visible without checking the box first).

While I get that there are situations when someone wants to enter the UEFI the next boot (but not immediately!), I think in most cases one wants to actually restart and enter the UEFI immediately (!).

With my suggestion both use cases are covered, while saving the one who wants to restart and enter the UEFI immediately is spared at least 2 clicks.