Bug 440328 - Two options for changing the visibility of the menu bar
Summary: Two options for changing the visibility of the menu bar
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 21.07.80
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-27 13:22 UTC by popov895
Modified: 2021-09-20 19:42 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 21.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2021-07-27 13:22:12 UTC
SUMMARY

Currently where are two options for changing the visibility of the menu bar: the first in the menu (Settings > Show Menubar) and the second in the configuration dialog (General > Show menubar). The first option changes the visibility of the menu bar for the current Konsole instance, and the second changes the visibility of the menu bar at startup. I believe there should only be one option for this, and it should be in the menu (just like in other KDE apps). Or am I missing something?

SOFTWARE/OS VERSIONS

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Nate Graham 2021-07-28 14:01:05 UTC
Given that the one in the settings window is not profile-specific, I am inclined to agree. The one in the configuration window should be removed, and the one in the Settings menu should be remembered across launches, just like in other KDE apps.

And we should also implement KHamburgerMenu for Konsole when the menubar is hidden. :)
Comment 2 Bug Janitor Service 2021-07-28 15:48:30 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/446
Comment 3 Kurt Hindenburg 2021-09-20 19:38:56 UTC
Git commit 5fc0c180f1efb90d819c69f9eb3575eb49dcfdf7 by Kurt Hindenburg, on behalf of Eugene Popov.
Committed on 20/09/2021 at 18:54.
Pushed by hindenburg into branch 'master'.

Use one option to control menubar visibility

Currently there are two options to control menubar visibility: the first in the menu and the second in the preferences dialog, moreover the second option makes the changes persistent. This MR removes the second option (from the preferences dialog) and makes the first option (from the menu) make the changes persistent.

M  +14   -13   src/MainWindow.cpp
M  +7    -5    src/MainWindow.h
M  +0    -2    src/settings/GeneralSettings.cpp
M  +69   -95   src/settings/GeneralSettings.ui
M  +0    -10   src/settings/konsole.kcfg

https://invent.kde.org/utilities/konsole/commit/5fc0c180f1efb90d819c69f9eb3575eb49dcfdf7