Bug 440271 - 2.26.1 still installs skrooge_unit.knsrc to depreciated /etc/xdg/ location
Summary: 2.26.1 still installs skrooge_unit.knsrc to depreciated /etc/xdg/ location
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-25 18:03 UTC by Rik Mills
Modified: 2021-07-25 20:10 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/office/skrooge/commit/dcbbb3e44f239032588e09b569e2ff358e4c096e
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2021-07-25 18:03:52 UTC 
SUMMARY

The 2.26.1 changelog includes:

* Correction: Fix deprecated knsrc file location

skrooge_monthly.knsrc had its location set to /usr/share/knsrcfiles/ with

plugins/skrooge/CMakeLists.txt:INSTALL(FILES skrooge_monthly.knsrc DESTINATION ${KDE_INSTALL_KNSRCDIR})

however skrooge_unit.knsrc is still being installed to /etc/xdg/ via:

plugins/skrooge/skrooge_unit/CMakeLists.txt:INSTALL(FILES skrooge_unit.knsrc DESTINATION ${CONFIG_INSTALL_DIR}

In my Ubuntu test build
Comment 1 Stephane MANKOWSKI 2021-07-25 20:10:57 UTC 
Git commit dcbbb3e44f239032588e09b569e2ff358e4c096e by Stephane MANKOWSKI.
Committed on 25/07/2021 at 20:09.
Pushed by smankowski into branch 'master'.

2.26.1 still installs skrooge_unit.knsrc to depreciated /etc/xdg/ location

M  +1    -0    CHANGELOG
M  +1    -1    plugins/skrooge/skrooge_unit/CMakeLists.txt

https://invent.kde.org/office/skrooge/commit/dcbbb3e44f239032588e09b569e2ff358e4c096e