Bug 440022 - PC3 RoundButton needs to be reworked
Summary: PC3 RoundButton needs to be reworked
Status: CONFIRMED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-19 03:05 UTC by Noah Davis
Modified: 2024-09-08 20:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Noah Davis 2021-07-19 03:05:18 UTC
SUMMARY
Not sure this can be done without breaking changes, but PC3 RoundButton is just not good.  I'm just noting it here for the future. It needs a number of changes:

- Width needs to be able to expand or shrink without the background turning into an oval. Could be done with FrameSvg, but the svg RoundButton currently uses ("widgets/actionbutton") is not an SVG suitable for FrameSvg. A new SVG is needed.
- Overall size needs to be able to expand or shrink without increasing or decreasing the size of certain details such as borders. Strongly related to the previous issue.
- Corners need to stay rounded when RoundButton has text.
- Implicit size calculation needs to be reworked to be consistent with other buttons. This is easy, except that it requires fixing the 1st and 2nd issues in order to look right.
- Radius property should work. Is this incompatible with SVG theming?