SUMMARY When the toolbar is hidden, a location bar should always be shown. The location bar (which appears inside each tab) is currently not shown if a hidden toolbar contains the 'location bar' item. This behaviour is confusing. STEPS TO REPRODUCE 1. Open Dolphin in the default layout (i.e. the toolbar contains a 'location bar' item) 2. Hide the toolbar (Uncheck 'Hamburger menu > more actions > Settings > show toolbar' or just 'Settings > Show toolbar' if the menubar is visible) 3. Now, show the toolbar again (Right click in the folder view area > Menu > Show toolbar) 4. Right click on the toolbar to Configure it, remove the 'Location Bar' item, and press 'OK'. OBSERVED RESULTS A location bar is shown after step 4, but not after step 2. EXPECTED RESULTS If the toolbar is hidden, a location bar should be shown regardless of whether the hidden toolbar contains a 'location bar' item. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.22.3 KDE Frameworks Version: 5.84.0 Qt Version: 5.15.2 ADDITIONAL INFORMATION
Honestly, I don't see any problem with current behavior. If I choose something to hide, it's because I don't want to see it. And displaying another panel after hiding one makes the shortcut multifunction. In other words, clicking Show/Hide Toolbar would not be enough to describe the action of this option, rather "Show/Hide Toolbar And show location bar inside the tab" would. A complete mess and unnecessary complexity. An option to toggle between displaying the location in/out of the tab would make more sense, but it's nothing you can't do right now and I still don't think it's worth the effort, because I don't see any use for it. Just my personal opinion.
>Just my personal opinion. Not just your personal opinion. :) This was also pretty much my reasoning for having it this way and not implementing some seemingly random extra behaviour when a user chooses to hide the toolbar. If I was to implement it in a way so the location bar is always visible even after hiding the toolbar, I think we would instead get bug reports about users not being able to hide the location bar at all. Sorry Kishore Gopalakrishnan but this is intentional. I think the benefits of changing it do not outweigh the drawbacks.
Would you at least consider adding a toggle to show/hide the in-tab location bar (similar to 'Settings > Show Toolbar')? The item could be called 'show dedicated location bar' or 'show in-tab location bar'. The current behaviour is quite undiscoverable. For example, I knew that there was a way to get the location bar to be inside each tab (since I had that on another machine), but I still had to fiddle with the configuration for a few minutes before remembering that I had to remove the 'location bar' item in the toolbar.
>Would you at least consider adding a toggle to show/hide the in-tab >location bar (similar to 'Settings > Show Toolbar')? The item could >be called 'show dedicated location bar' or 'show in-tab location bar'. I would definitely consider this. Actually I originally had it implemented this way. Video proof: https://phabricator.kde.org/file/data/qtwbr6gbknjyhk5soaia/PHID-FILE-33ovd2e4n6zjt67j6ur5/2020-02-20_16-50-45.mp4 :) It wasn't really popular among other contributors for good reasons. The designers didn't like that there is a separate toggle option for removing something from a toolbar when we already have a way for that especially because most users are probably not interested in moving their location bar. Developers didn't like that I was messing with the toolbar configuration of users because this is a bit dangerous because it can put a users configuration in a state so Dolphin crashes on every start. It's also somewhat tricky to implement in general for something that doesn't seem extremely important. Please open another bug report if you want to re-ignite that discussion. I wouldn't want to re-implement this unless there seems to be some consensus and demand.