Bug 439894 - Implement KHamburgerMenu
Summary: Implement KHamburgerMenu
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: 21.04.2
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-15 17:03 UTC by Podagric
Modified: 2022-10-15 11:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Podagric 2021-07-15 17:03:04 UTC
SUMMARY
This implementation has already been done in other KDE apps and can be used as a reference:
Dolphin: https://invent.kde.org/system/dolphin/-/merge_requests/71
Gwenview: https://invent.kde.org/graphics/gwenview/-/merge_requests/70
KMail: https://invent.kde.org/pim/kmail/-/commit/67743a529773302fd2180c8f1a752e2534f29775

It is also related to the issue where I proposed some changes to better organize kate large list of functions: https://bugs.kde.org/show_bug.cgi?id=439414
Comment 1 Nate Graham 2021-08-03 04:23:33 UTC
I think Kate might be a poor candidate for KHamburgerMenu, actually. It simply has so much functionality that I think it would be hard to implement without hiding too much of it or making the hamburger menu so tall that it defeats the point.

Willing to be proven wrong, of course. :)
Comment 2 Podagric 2021-08-03 11:30:09 UTC
makes sense. I suggested some changes in bug 439414
Comment 3 Podagric 2022-03-31 22:36:45 UTC
I've seen the great progress made using the same codebase between kate and kwrite and i think the khaburguermenu implementation would be more welcome than ever now. KWrite could hide the menu bar entirely and have a much more minimalist interface
Comment 4 Nate Graham 2022-04-01 03:18:22 UTC
It might (emphasis on might) work for KWrite, but I still very much doubt we could make KHamburgerMenu work for Kate. Its menu structure is just too big. Too many things would be hidden and made less conveniently accessible.
Comment 5 Christoph Cullmann 2022-04-01 05:01:54 UTC
I fail to see how that improves usability for KWrite.

And it will break again the consistency we now reached between KWrite and Kate menu structure.
Comment 6 Christoph Cullmann 2022-04-01 18:16:34 UTC
What I could see: If one hides the menu bar, one could add it as a hamburger menu as is, to still have it accessible via the toolbar.
Or is that not feasible with how the hambuger menu stuff works?
Comment 7 Nate Graham 2022-04-01 19:18:14 UTC
That's exactly how it works, in fact.

The exact contents of the hamburger menu are customizable. So you could just stick the existing menu structure in there. I guess that could be a way to implement it without tearing out your hair trying to come up with a curated selection of menu items, the way we do in Dolphin, Gwenview, and Okular.
Comment 8 Christoph Cullmann 2022-04-01 19:25:01 UTC
If somebody provides a merge request for just that: If one toggles the "Show menu" option we already have to "off" => add KHamburgerMenu to toolbar, that would be acceptable.

This would then at least be consistent in both applications, as now the code is shared.

If it makes that much sense is a different question, but if people just want to hide the menu to have a cleaner style, so be it.