Bug 439883 - onlinequoteeditor5 not included in kmymoney binaries generated by KDE CI
Summary: onlinequoteeditor5 not included in kmymoney binaries generated by KDE CI
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: packaging (show other bugs)
Version: 5.1.2
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks: 426400 435761
  Show dependency treegraph
 
Reported: 2021-07-15 12:09 UTC by Ralf Habacker
Modified: 2024-04-18 07:57 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2021-07-15 12:09:16 UTC
onlinequoteeditor is provided by the alkimia package, which is included in binary builds for kmymoney, but the mentioned executable is excluded by packaging.

STEPS TO REPRODUCE
1. download kmymoney binary build from https://binary-factory.kde.org/job/KMyMoney_Nightly_win64/
2. unpack the archive and inspect the bin folder

OBSERVED RESULT
There is no file named onlinequoteeditor5.exe

EXPECTED RESULT
That file should be present

ADDITIONAL INFORMATION
The online quotes editor provides advanced features for editing and testing online quotes sources and can be a useful addition to kmymoney.
Comment 1 Ralf Habacker 2021-07-15 21:53:57 UTC
I just recognized that the online quotes editor is already available for Windows at  at https://binary-factory.kde.org/job/Alkimia_Nightly_win64/, so that would an alternative to this feature request.
Comment 2 Thomas Baumgart 2024-04-09 05:50:56 UTC
Git commit 766ecafaee502ad9fc9417402e176bb41d392111 by Thomas Baumgart.
Committed on 09/04/2024 at 05:50.
Pushed by tbaumgart into branch 'master'.

[kmymoney] Include additional executables in package
FIXED-IN: 5.2

M  +1    -1    extragear/kmymoney/blacklist.txt

https://invent.kde.org/packaging/craft-blueprints-kde/-/commit/766ecafaee502ad9fc9417402e176bb41d392111
Comment 3 Ralf Habacker 2024-04-17 09:13:20 UTC
(In reply to Thomas Baumgart from comment #2)

> https://invent.kde.org/packaging/craft-blueprints-kde/-/commit/766ecafaee502ad9fc9417402e176bb41d392111

This change is not recognizable in the current CI build https://cdn.kde.org/ci-builds/office/kmymoney/master/windows/kmymoney-master-3196-windows-cl-msvc2019-x86_64.7z

Possibly increasing the patch level could help here, as was done in an earlier commit, see https://invent.kde.org/packaging/craft-blueprints-kde/-/commit/766ecafaee502ad9fc9417402e176bb41d392111
Comment 4 Thomas Baumgart 2024-04-17 13:04:12 UTC
Git commit e246114945b04bed1e9235c5f99e61326f30d28a by Thomas Baumgart.
Committed on 17/04/2024 at 13:04.
Pushed by tbaumgart into branch 'qt5-lts'.

[kmymoney] Include additional executables in package

M  +1    -1    extragear/kmymoney/blacklist.txt

https://invent.kde.org/packaging/craft-blueprints-kde/-/commit/e246114945b04bed1e9235c5f99e61326f30d28a
Comment 5 Thomas Baumgart 2024-04-18 07:57:02 UTC
I verified that onlinequoteseditor5.exe is now in the build again. Changes to the craft blueprint need to be made on the qt5-lts branch to take effect. Hence I close this ticket again.