Bug 439774 - Paint assistants does not follow stylus because Pen Pointer Input (WinInk) on canvas does not move system cursor
Summary: Paint assistants does not follow stylus because Pen Pointer Input (WinInk) on...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tablets (tablet issues are only very rarely bugs in Krita!) (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-12 07:48 UTC by Alvin Wong
Modified: 2021-09-10 08:00 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvin Wong 2021-07-12 07:48:27 UTC
This can also be observed in the tablet tester, that the mouse move events are not sent during a stroke, but only the mouse down and up events are sent.

Here is the thing, if the widget handles tablet events and the QPA decides it should synthesize mouse events instead of letting Windows do it, it needs to do it for the whole stroke from start to finish (or until the pointer has been cancelled) by tracking with a flag, not by relying on whether the subsequent QTabletEvent's are accepted or not.
Comment 1 Alvin Wong 2021-07-26 14:27:24 UTC
Note: This issue appears to also cause dragging dockers with stylus to behave erratically. The dockers don't move until the stylus is released.
Comment 2 Bug Janitor Service 2021-09-09 13:39:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1047
Comment 3 Bug Janitor Service 2021-09-09 13:39:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1047
Comment 4 Alvin Wong 2021-09-10 08:00:05 UTC
Git commit e3a74996834a637092d89c9d15d723376f909ffd by Alvin Wong.
Committed on 10/09/2021 at 07:59.
Pushed by alvinwong into branch 'master'.

Add Qt patch to make mouse events from WinInk complete

A  +87   -0    3rdparty/ext_qt/0052-WinInk-Synthesize-mouse-events-for-full-pen-stroke.patch
M  +1    -0    3rdparty/ext_qt/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/e3a74996834a637092d89c9d15d723376f909ffd
Comment 5 Alvin Wong 2021-09-10 08:00:33 UTC
Git commit a60e51b08eae3f9706f6e58594be58a204e92bda by Alvin Wong.
Committed on 10/09/2021 at 08:00.
Pushed by alvinwong into branch 'krita/5.0'.

Add Qt patch to make mouse events from WinInk complete


(cherry picked from commit e3a74996834a637092d89c9d15d723376f909ffd)

A  +87   -0    3rdparty/ext_qt/0052-WinInk-Synthesize-mouse-events-for-full-pen-stroke.patch
M  +1    -0    3rdparty/ext_qt/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/a60e51b08eae3f9706f6e58594be58a204e92bda