Bug 439701 - Add to Predefined Patterns
Summary: Add to Predefined Patterns
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Resource Management (show other bugs)
Version: git master (please specify the git hash!)
Platform: Mint (Ubuntu based) Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-07-09 22:25 UTC by Tiar
Modified: 2021-07-27 12:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tiar 2021-07-09 22:25:37 UTC 
SUMMARY


STEPS TO REPRODUCE
1. Make some "pattern" on the canvas.
2. Go to Patterns popup.
3. Use "Custom" -> Add to Predefined Patterns.

OBSERVED RESULT
There is no pattern like that in Predefined Patterns popup (the one on the toolbar) afterwards.
It is however visible in Resource Manager.
A restart of Krita fixes it.
It looks like the popup somehow doesn't update even though not only the database is changed and the file is saved correctly, but even the models see the pattern (vide RM).

EXPECTED RESULT
The pattern should immediately be shown in the Predefined Patterns chooser in the patterns popup.

SOFTWARE/OS VERSIONS
git hash: 13f04ca236
Comment 1 Ahab Greybeard 2021-07-15 19:26:18 UTC 
I can confirn this for the July 15 5.0.0-prealpha (git 9d832b4) appimage.

With the 4.4.5 appimage, the added custom pattern can be seen in the Toolbar patterns popup and in the Patterns Docker immediately.
Hence regression.
Comment 2 Halla Rempt 2021-07-27 12:18:56 UTC 
Git commit 5d7a5e145377f2aa1bacf69b4cbc60675fb67321 by Halla Rempt.
Committed on 27/07/2021 at 12:16.
Pushed by rempt into branch 'master'.

Implement saving patters to predefined

M  +4    -1    libs/resources/KisResourceLocator.cpp
M  +1    -9    libs/ui/KisApplication.cpp
M  +9    -3    libs/ui/forms/wdgcustompattern.ui
M  +1    -1    libs/ui/kis_control_frame.cpp
M  +35   -16   libs/ui/kis_custom_pattern.cc

https://invent.kde.org/graphics/krita/commit/5d7a5e145377f2aa1bacf69b4cbc60675fb67321