Bug 439700 - Loop in Color Sampler
Summary: Loop in Color Sampler
Status: RESOLVED NOT A BUG
Alias: None
Product: krita
Classification: Applications
Component: Resource Management (show other bugs)
Version: git master (please specify the git hash!)
Platform: Mint (Ubuntu based) Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression, release_blocker
Depends on:
Blocks:
 
Reported: 2021-07-09 22:22 UTC by Tiar
Modified: 2021-07-27 12:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tiar 2021-07-09 22:22:21 UTC 
SUMMARY
I'm not sure what the impact is for the user, but I noticed it in the code so it needs to be checked.

There is a loop in palettes if the user uses both 1) a palette inside a document, 2) a color sampler to add new colors to the palette.
The loop is as follows:
Color Sampler updates the palette in the resource server, palette editor notices it by slotSetDocumentModified(), and that updates the palette in the resource server again, potentially triggering another slotSetDocumentModified() etc.

I haven't tested it so I don't know how it looks from the user perspective but it might lead to a freeze.

SOFTWARE/OS VERSIONS
git hash: 13f04ca236
Comment 1 Halla Rempt 2021-07-27 12:58:42 UTC 
I've tested this and I haven't seen any problems. It just works.