Bug 439679 - Minimum size of Animation Curves docker is too wide
Summary: Minimum size of Animation Curves docker is too wide
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-09 12:39 UTC by Alvin Wong
Modified: 2021-07-22 02:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvin Wong 2021-07-09 12:39:58 UTC
The Animation Curves docker seems to have a lot of tool buttons which is restricting the minimum size of the docker. For instance, the default Animation workspace is just a bit too big on a Surface Pro (2736x1824 at 200% scaling, i.e. 1368x912 logical size) and that causes the window to stretch beyond the screen by half a button.

Potential solutions:

- Make the tool buttons collapsible
- Add scrolling to the tool buttons (similar to the toolbox)
Comment 1 Eoin O'Neill 2021-07-21 21:35:15 UTC
Git commit aa53cd0d7190c46234e28b889b3480f352219a9a by Eoin O'Neill.
Committed on 21/07/2021 at 21:34.
Pushed by eoinoneill into branch 'master'.

KisAnimCurvesDocker: Made tangent mode buttons collapsible.

M  +6    -10   plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +1    -7    plugins/dockers/animation/KisAnimCurvesDocker.h

https://invent.kde.org/graphics/krita/commit/aa53cd0d7190c46234e28b889b3480f352219a9a
Comment 2 Eoin O'Neill 2021-07-21 21:35:23 UTC
Git commit 31d6b187f33f27f7c1f09b2428aeddce67ae4370 by Eoin O'Neill.
Committed on 21/07/2021 at 21:34.
Pushed by eoinoneill into branch 'master'.

Added collapsible button group to KisAnimCurvesDocker.

Allows a set of buttons / actions to contract down to a single
click and hold button.

If the widget has enough space, it will show all buttons in the group.

If it doesn't have enough space, it will collapse to  a single button.
The single button that's shown will be whichever button in the group that
was last used. Click and holding the collapsed button will open a menu
where other buttons in the group are accessible.

Buttons in a KisCollapsibleButtonGroup should ideally be logically related.

M  +1    -0    libs/ui/CMakeLists.txt
A  +128  -0    libs/ui/widgets/kis_collapsible_button_group.cpp  *
A  +45   -0    libs/ui/widgets/kis_collapsible_button_group.h  *
M  +9    -15   plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +2    -3    plugins/dockers/animation/KisAnimCurvesDocker.h

The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page.


https://invent.kde.org/graphics/krita/commit/31d6b187f33f27f7c1f09b2428aeddce67ae4370
Comment 3 Eoin O'Neill 2021-07-21 21:35:32 UTC
Git commit d2f3fb202be90ffa1a531b4603f775fbd860df22 by Eoin O'Neill.
Committed on 21/07/2021 at 21:34.
Pushed by eoinoneill into branch 'master'.

KisAnimCurvesDocker: Added zoom fit operations to a collapsible button group.

M  +1    -0    libs/ui/widgets/kis_collapsible_button_group.cpp
M  +6    -11   plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +1    -2    plugins/dockers/animation/KisAnimCurvesDocker.h

https://invent.kde.org/graphics/krita/commit/d2f3fb202be90ffa1a531b4603f775fbd860df22
Comment 4 Emmet O'Neill 2021-07-22 02:43:01 UTC
Git commit 1ed4d77b7f6d3f0de3a8137e5740add7b4f08b7f by Emmet O'Neill.
Committed on 22/07/2021 at 02:42.
Pushed by emmetoneill into branch 'master'.

Fix bug on GNOME system where collapsible buttons were not rendering.

Since Eoin tested this on a KDE machine, he didn't notice that the
action icons weren't visible on the dropdown. This fixes that,
and adds some already localized text elements by using the tooltip.

Once we're out of string freeze, we should try making a set of unique
strings here...

M  +8    -0    libs/ui/widgets/kis_collapsible_button_group.cpp

https://invent.kde.org/graphics/krita/commit/1ed4d77b7f6d3f0de3a8137e5740add7b4f08b7f