Bug 439378 - Merging 2 directories using rename fails with keyboard navigation
Summary: Merging 2 directories using rename fails with keyboard navigation
Status: REOPENED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 21.04.2
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-01 17:23 UTC by kde.org
Modified: 2021-07-01 20:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the "Already exists as folder window" (42.89 KB, image/png)
2021-07-01 17:23 UTC, kde.org
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kde.org 2021-07-01 17:23:54 UTC
Created attachment 139791 [details]
Screenshot of the "Already exists as folder window"

SUMMARY
Merging 2 directories using rename fails with keyboard navigation, but works using the mouse.

STEPS TO REPRODUCE
1. mkdir -p test/d1 test/d2
2. touch test/d1/f1 test/d2/f2
3. In the details file view, select directory d2 and press F2 and rename it to 'd1', press return
4. A window with title "Already exists as Folder" pops up, as expected.
5. Press the Tab key twice to highlight/move the focus to the "Write Into" button. (Screenshot attached) 
6. Press enter.

OBSERVED RESULT
Window with title "Already exists as Folder" closes, but directory "d2" is NOT merged with d1.

EXPECTED RESULT
window with title "Already exists as Folder" closes, directory "d1" contains two files "f1","f2", "d2" is deleted.

Please note that this used to work with keyboard navigation and still works if the button "Write Into" is clicked using the mouse.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro Arch stable, up to date
Kernel: 5.10.42-1-MANJARO
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 kde.org 2021-07-01 17:28:43 UTC
I played around with this a bit more and noticed that it works when pressing the space bar in step 6 instead of the return key. So most likely the binding for the return key got lost (or always bound to the "Cancel" button?)
Comment 2 Nate Graham 2021-07-01 19:23:29 UTC
This is intentional; the spacebar key is what triggers the focused button/UI element. When the return/enter key also does, this is a nice little bonus, but not something you're supposed to rely on, as it requires the app to specifically implement support for that. Some do out of necessity, e.g. music players where the spacebar is often bound to the play/.pause function. But beyond that, it's best to always be in the habit of using the spacebar. :)
Comment 3 kde.org 2021-07-01 19:38:09 UTC
Hi Nate, 

thanx for looking into this so quickly! I'm not sure this is intentional. This used to work before my last update. It works in Dolphin in all other windows I tried, e.g. press F10 to create a new directory, use the tab key to select the Cancel button, press return -> directory is not created.
Press F10 again, use the tab key to navigate to the OK button, press return -> directory is created. So the return key invokes the current selection. Would be great if it did that again for the "Already exists as Folder" window as well.
From a user perspective it's surprising that it doesn't work in this particular window, but in most (all?) other windows of dolphin.
Are there any usability guidelines that describe what is supposed to happen when the user presses the return key?

P.S.: I love your blog! :-)
Comment 4 Nate Graham 2021-07-01 19:59:23 UTC
Is there any chance you are using the git master version of Breeze?
Comment 5 kde.org 2021-07-01 20:08:34 UTC
I am using current stock kde manjaro arch stable and haven't installed or messed with any themes. 

When I look at plasma style, I see that "Breeze Dark" is selected.
In application style, I see that "Breeze" is selected.

$ pacman -Q | grep -i breeze
breeze 5.21.5-2
breeze-icons 5.82.0-1

$ pacman -Q | grep -i plasma
kdeplasma-addons 5.21.5-1
plasma-desktop 5.21.5-1
plasma-framework 5.82.0-1
plasma-integration 5.21.5-1
plasma-nm 5.21.5-1
plasma-pa 5.21.5-1
plasma-wayland-session 5.21.5-1
plasma-workspace 5.21.5-1
plasma-workspace-wallpapers 5.21.5-1
plasma5-themes-breath 0.4.0-2
plasma5-themes-breath2 1.0.13-1


Is there any other information I can provide to analyze this better?
Does pressing return work for you when renaming the directory with the theme you are using?