Bug 439374 - Popups of widgets placed on desktop have a visual glitch
Summary: Popups of widgets placed on desktop have a visual glitch
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.22.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords: regression
: 444305 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-07-01 12:15 UTC by Patrick Silva
Modified: 2022-02-07 16:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.24.1
Sentry Crash Report:


Attachments
screenshot (485.51 KB, image/png)
2021-07-01 12:15 UTC, Patrick Silva
Details
screen recording (892.17 KB, video/webm)
2021-10-25 17:14 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-07-01 12:15:23 UTC
Created attachment 139782 [details]
screenshot

STEPS TO REPRODUCE
1. add User Switcher widget to desktop and click on it
2. 
3. 

OBSERVED RESULT
glich seen in the attached screenshot

EXPECTED RESULT
no glitch

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Patrick Silva 2021-09-19 15:11:32 UTC
In fact, any widget placed on desktop that opens a popup is affected:

Application menu (kicker)
Application launcher (kickoff)
notifications
network
media player
Disks & Devices
lock keys status
System tray
Comment 2 David Edmundson 2021-09-25 23:36:16 UTC
It's this:


CompactApplet.qml:202
            // Draws a line between the applet dialog and the panel
            PlasmaCore.SvgItem {
Comment 3 David Edmundson 2021-09-25 23:40:46 UTC
Potentially just needs a:

visible: plasmoid.location == left || plasma.location == top || .. 

Or maybe you can just use the form factor.
Comment 4 Bug Janitor Service 2021-09-27 16:43:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/576
Comment 5 Bug Janitor Service 2021-09-28 10:19:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/577
Comment 6 Nate Graham 2021-09-28 16:56:10 UTC
Git commit 864b04dee5cc6f855047149be0b6e00a5cbee3fd by Nate Graham.
Committed on 28/09/2021 at 16:55.
Pushed by ngraham into branch 'master'.

CompactApplet: Only draw separator line for panel applets

The purpose of this line is to separate a panel applet's popup from the
panel, but when there is no panel, the line gets drawn anyway, has
undefined geometry, ends up too big, and looks weird. This commit hides
it for the popups of non-panel applets.
FIXED-IN: 5.23

M  +3    -0    desktoppackage/contents/applet/CompactApplet.qml

https://invent.kde.org/plasma/plasma-desktop/commit/864b04dee5cc6f855047149be0b6e00a5cbee3fd
Comment 7 Nate Graham 2021-09-28 16:56:36 UTC
Git commit 27b85c1716c33648e7caf3c2efd78c0c86dff9f1 by Nate Graham.
Committed on 28/09/2021 at 16:56.
Pushed by ngraham into branch 'Plasma/5.23'.

CompactApplet: Only draw separator line for panel applets

The purpose of this line is to separate a panel applet's popup from the
panel, but when there is no panel, the line gets drawn anyway, has
undefined geometry, ends up too big, and looks weird. This commit hides
it for the popups of non-panel applets.
FIXED-IN: 5.23


(cherry picked from commit 864b04dee5cc6f855047149be0b6e00a5cbee3fd)

M  +3    -0    desktoppackage/contents/applet/CompactApplet.qml

https://invent.kde.org/plasma/plasma-desktop/commit/27b85c1716c33648e7caf3c2efd78c0c86dff9f1
Comment 8 Patrick Silva 2021-10-24 12:01:53 UTC
*** Bug 444305 has been marked as a duplicate of this bug. ***
Comment 9 Patrick Silva 2021-10-24 13:02:32 UTC
Not completely fixed, can reproduce with System Tray on neon unstable.
See bug 444305.
Comment 10 Nate Graham 2021-10-25 15:17:23 UTC
Cannot reproduce. If you clear the contents of ~/.cache and restart plasmashell, does it go away?
Comment 11 Patrick Silva 2021-10-25 17:14:57 UTC
Created attachment 142860 [details]
screen recording

The whole popup is in dark grey after clearing cache. Watch the attached screen
recording please.
Comment 12 Nate Graham 2021-10-26 15:19:52 UTC
wat

Still cannot reproduce... :(
Comment 13 Nate Graham 2022-02-07 16:58:46 UTC
That turned out to be a separate issue which is now fixed.