Bug 439292 - Variable list doesn't update properly when string variable is added to script
Summary: Variable list doesn't update properly when string variable is added to script
Status: RESOLVED FIXED
Alias: None
Product: SeExpr
Classification: Frameworks and Libraries
Component: General (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-29 10:45 UTC by Alvin Wong
Modified: 2021-07-01 01:29 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/kseexpr/commit/f8823f7db220aa203c869574dbaf17e8c1558380
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alvin Wong 2021-06-29 10:45:56 UTC 
If a string variable is added to the script, all variables after it and including the string variable does not appear on the list of variable widgets.
Comment 1 amyspark 2021-06-30 13:10:09 UTC 
Will fix; but please note that string variables aren't used anywhere in the code. (I guess that they are for internal tools of Disney's.)
Comment 2 Alvin Wong 2021-06-30 13:22:07 UTC 
I see. Perhaps might as well just hide the tab for adding string variables?
Comment 3 amyspark 2021-07-01 00:48:34 UTC 
Not necessary. But I think an ABI break may be needed to bring string UI controls to parity with the rest.
Comment 4 amyspark 2021-07-01 01:29:24 UTC 
Git commit f8823f7db220aa203c869574dbaf17e8c1558380 by L. E. Segovia.
Committed on 01/07/2021 at 00:49.
Pushed by lsegovia into branch 'master'.

Update the UI parser to enable string variables

M  +319  -328  generated/KSeExprUI/ExprSpecParser.cpp
M  +3    -3    generated/KSeExprUI/ExprSpecParser.tab.h
M  +51   -52   generated/KSeExprUI/ExprSpecParserLexIn.cpp
M  +1    -6    src/KSeExprUI/ExprSpecParser.y

https://invent.kde.org/graphics/kseexpr/commit/f8823f7db220aa203c869574dbaf17e8c1558380