Bug 439175 - Make QtWebkitWidgets optional / remove the dependency
Summary: Make QtWebkitWidgets optional / remove the dependency
Status: RESOLVED FIXED
Alias: None
Product: cantor
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Semke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-26 09:18 UTC by Luca Beltrame
Modified: 2021-06-26 10:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 21.08
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Beltrame 2021-06-26 09:18:57 UTC
The recent merging of the documentation branch in cantor (master) added both a dependency on QWebEngine and QtWebKitWidgets.

The latter is part of the unmaintained and unsupported QtWebKit (save for a third party fork not everyone ships), which some distributions are removing. 

Thus, the dependency on QtWebKitWidgets (which looks unused from a quick glance in the code, but I might be mistaken) should be either removed entirely (if unused) or made optional (if used) to allow also building on distributions which do not ship, or plan to not ship QtWebKit anymore (such as openSUSE).
Comment 1 Alexander Semke 2021-06-26 10:56:44 UTC
Git commit ea56d70e0857f72aa25c9abb6f29f0a62857d27d by Alexander Semke.
Committed on 26/06/2021 at 10:56.
Pushed by asemke into branch 'master'.

Removed the dependency on QtWebkitWidgets and on some other libraries in the new documentation panel code.
FIXED-IN: 21.08

M  +0    -1    CMakeLists.txt
M  +0    -5    src/panelplugins/documentationpanel/CMakeLists.txt

https://invent.kde.org/education/cantor/commit/ea56d70e0857f72aa25c9abb6f29f0a62857d27d
Comment 2 Alexander Semke 2021-06-26 10:58:02 UTC
(In reply to Luca Beltrame from comment #0)
> The recent merging of the documentation branch in cantor (master) added both
> a dependency on QWebEngine and QtWebKitWidgets.
I removed this dependency now. Thanks for pointing this out!