Bug 439116 - gmic-qt plugin automatically connects to server to check for update without user consent
Summary: gmic-qt plugin automatically connects to server to check for update without u...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: unspecified Unspecified
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-24 15:39 UTC by Alvin Wong
Modified: 2021-07-05 13:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvin Wong 2021-06-24 15:39:04 UTC
We require users to manually enable automatic update check and the news feed, yet the gmic-qt plugin has automatic updates enabled by default. This seems wrong.

I think we should also be disabling g'mic updates by default.
Comment 1 Bug Janitor Service 2021-06-27 02:27:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/930
Comment 2 Dmitry Kazakov 2021-06-29 06:20:05 UTC
Git commit 8ac346a257fe3957fa3c985e059e527a2b26697d by Dmitry Kazakov, on behalf of L. E. Segovia.
Committed on 29/06/2021 at 06:19.
Pushed by dkazakov into branch 'master'.

GMic: consistency updates

- Disable its theming support when the host is Krita
- Disable internet access by default
- Fix on-launch update (if enabled) on slow connections

M  +1    -1    3rdparty_plugins/ext_gmic/0001-First-working-version-of-the-GMic-Qt-Krita-native-pl.patch
M  +1    -1    3rdparty_plugins/ext_gmic/0002-Remove-shared-segment-infrastructure.patch
M  +1    -1    3rdparty_plugins/ext_gmic/0003-Refactor-into-a-completely-Krita-native-plugin.patch
M  +1    -1    3rdparty_plugins/ext_gmic/0004-Enable-all-input-modes-for-Krita-plugin.patch
M  +1    -1    3rdparty_plugins/ext_gmic/0005-Update-function-signatures-to-2.9.6.patch
M  +1    -1    3rdparty_plugins/ext_gmic/0006-Add-support-for-MSVC.patch
A  +84   -0    3rdparty_plugins/ext_gmic/0007-Disable-GMic-Qt-s-own-theming-for-Krita.patch
A  +75   -0    3rdparty_plugins/ext_gmic/0008-Add-flag-to-disable-internet-access-by-default.patch
A  +25   -0    3rdparty_plugins/ext_gmic/0009-Increase-on-launch-update-timeout-to-60s.patch

https://invent.kde.org/graphics/krita/commit/8ac346a257fe3957fa3c985e059e527a2b26697d
Comment 3 amyspark 2021-07-05 13:05:20 UTC
Git commit 275c5cbaeb7718dd07a5deda45caecae2176547a by L. E. Segovia.
Committed on 05/07/2021 at 13:04.
Pushed by lsegovia into branch 'master'.

GMic: apply consistency patches

M  +3    -0    3rdparty_plugins/ext_gmic/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/275c5cbaeb7718dd07a5deda45caecae2176547a