Bug 439038 - [RFE] Should plasma-nm create system connections when allowed to?
Summary: [RFE] Should plasma-nm create system connections when allowed to?
Status: RESOLVED NOT A BUG
Alias: None
Product: plasmashell
Classification: Plasma
Component: Networks widget (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Jan Grulich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-22 21:34 UTC by Andrew Zaborowski
Modified: 2024-12-23 18:26 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Zaborowski 2021-06-22 21:34:50 UTC
plasma-nm always sets a new connection's permissions property to the current user, meaning that only that user can use that connection: https://github.com/KDE/plasma-nm/blob/6cac88b61da1277dcb9a801e47f2d69829c68086/libs/handler.cpp#L234

Similarly the editor's default value for the `allUsers` checkbox is false (not really sure if that is ever used.. or is the editor window only ever initialized with values from an existing connection in a way that the defaults never come into play).

Apparently the approach recommended by NM creators is for the client to look at the `org.freedesktop.NetworkManager.settings.modify.system` polkit permission and if that is true for the current user session, default to a system-owned new connection (empty `permissions` property), otherwise default to user-owned.  This was recently stated in https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/743#note_952026 (and, as can be seen in that link I'm interested in making this logic work across all clients because when NM is switched to use IWD as the wifi backend -- a recent addition -- some features can only be enabled for system-owned connections.  But, I don't currently have a plasma setup to be able to try making the necessary plasma-nm changes)

For reference I documented what different NM clients do in https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/98
Comment 1 Jan Grulich 2021-06-25 15:31:53 UTC
Even if we enable new connections for all users, we still default to store secrets into KWallet (obviously for security reasons) so only the current user will have passwords to created connections.

With this scenario I don't see a benefit in changing the default.
Comment 2 Nate Graham 2021-07-29 16:04:35 UTC
Indeed.
Comment 3 Andrew Zaborowski 2021-07-29 19:13:09 UTC
Ok, in that case there's probably nothing that can be done at this time.
Comment 4 Ben Cooksley 2024-12-23 18:26:06 UTC
Bulk transfer as requested in T17796