Bug 439009 - Added color change toolbar button (okular part) only shown for current tab but affects all tabs (fixed by restart)
Summary: Added color change toolbar button (okular part) only shown for current tab bu...
Status: RESOLVED DUPLICATE of bug 457115
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 21.04.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-21 20:04 UTC by postix
Modified: 2022-07-25 13:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2021-06-21 20:04:54 UTC 
STEPS TO REPRODUCE
1. Open several documents in tabs
2. Right click on the tool bar, add e.g. "toggle colors" to the toolbar
3. Press the button, the colors should flip
4. Switch the tab

OBSERVED RESULT

The button is gone, the colors are flipped. 
After a new instance of Okular is started, the button is shown for all tabs as expected.


EXPECTED RESULT

The button is there.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20210618
KDE Plasma Version: 5.22.0
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2
Kernel Version: 5.12.10-1-default (64-bit)
Graphics Platform: X11
Comment 1 Laura David Hurka 2021-06-22 11:33:12 UTC 
I tried this with Add Bookmark, and:

1. Add ‘Add Bookmark’.
2. Switch to other tab.
3. ‘Add Bookmark’ gone.
4. Trigger ‘Toggle Change Colors’.
5. ‘Add Bookmark’ appears.

I remember that Toggle Change Colors calls refreshActionProperties(), and commit d4bf5bc873e1a4ef4207ed77bbcacb14b382bd9b in KXmlGui should have fixed it. Apparently it still doesn’t work.
Comment 2 postix 2022-07-25 13:12:10 UTC 
I have opened a new bug report, which describes the issue better.

*** This bug has been marked as a duplicate of bug 457115 ***