Bug 438970 - All effects in timeline disabled and cannot be re-enabled after using Disable Timeline Effects and saving
Summary: All effects in timeline disabled and cannot be re-enabled after using Disable...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: 21.04.2
Platform: Appimage Linux
: NOR major
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-21 01:15 UTC by Ryan K
Modified: 2024-04-16 07:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
fritzibaby: Brainstorm+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan K 2021-06-21 01:15:20 UTC
Working on a large project and noticed all my effects became greyed out and inactive. 

I believe this is related to Timeline menu item Disable Timeline Effects. In the project with the problem I had enabled this to more quickly work with greenscreened video but then forgot I had done so and began to panic when everything was inactive. I reloaded the file and that didn't help, but then I remembered the Disable Timeline Effects toggle. It was off, but toggling it on and off didn't help.

I checked the save file and 
<property name="kdenlive:docproperties.disabletimelineeffects">1</property>
was set.
I tried changing that to 0 and it didn't help. Tried deleting the property but that didn't help either.

Is there anything else I can try? Would be days of work to recreate the project.


STEPS TO REPRODUCE
1. Create new project
2. Add a clip
3. Add effect to clip e.g. Transform
4. Menu Timeline > Disable Timeline Effects (toggle on)
5. Save project
6. Revert project
7. Menu Timeline > Disable Timeline Effects (toggle off)

OBSERVED RESULT
Timeline effects on the clip are still disabled.

EXPECTED RESULT
Timeline effects on the clip are enabled and disabled by the toggle.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Ubuntu 18.04
AppImage: kdenlive-21.04.2-x86_64.appimage


ADDITIONAL INFORMATION
Comment 1 Ryan K 2021-06-21 14:36:19 UTC
OK, did more tests on a simple example.

Disable Timeline Effects + Save writes:

<property name="kdenlive:docproperties.disabletimelineeffects">1</property>

as well as:

<property name="disable">1</property>

in the producer.

Reloading or reverting the project then gets things out of sync, where the UI untoggles Disable Timeline Effects but it is left in the save file.

It seems like the <property name="disable">1</property> disables the effects since removing the disabletimelineeffects property doesn't re-enable effects.

If I remove both properties then the effects are re-enabled. I'll give this a try with my original file.

There is also a
<property name="kdenlive:activeeffect">0</property>
that appears in my .kdenlive save diffs that appears in the enabled effects version (saved before Disable Timeline Effects) that doesn't in the disabled effects version?
Comment 2 Ryan K 2021-06-21 15:47:41 UTC
Can confirm that removing the spurious disable properties on each effect in the .kdenlive save file did fix the problem in my original project file.

So it seems there are two issues:
- UI does not track disabletimelineeffects property (i.e. doesn't restore the UI toggle state based on the property)
- setting disabled on the effects should only be used for individual manual disabling (otherwise temporary disable will overwrite the manual disable state)


Thanks!
Comment 3 emohr 2021-06-27 09:23:39 UTC
Thank you for reporting. I can confirm this behavior. Ones Disable Timeline Effects is toggle on and the project is saved you only can enable the effects individually.

Thank you or the investigation it will help to solve it.
Comment 4 diekuhrannte@web.de 2024-03-29 19:39:16 UTC
Can you please report whether the problem still exists? Or can we close the bug report?
Comment 5 Bug Janitor Service 2024-04-13 03:47:58 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Ryan K 2024-04-13 13:40:55 UTC
Yes, I was able to reproduce right now using 24.02.1.

Disable timeline effects should either be a UI-only state that isn't saved to the file or a separate global property rather than and individual one.
Comment 7 Jean-Baptiste Mardelle 2024-04-16 07:57:00 UTC
Git commit 984dec0103b12782dae83e0e292a988db6c23c88 by Jean-Baptiste Mardelle.
Committed on 16/04/2024 at 07:55.
Pushed by mardelle into branch 'master'.

Fix effects cannot be enabled after saving with disable bin/timeline effects
Faster project opening for multi-timeline projects

M  +2    -3    src/bin/bin.cpp
M  +4    -4    src/bin/clipcreator.cpp
M  +0    -4    src/effects/effectstack/model/abstracteffectitem.cpp
M  +1    -1    src/effects/effectstack/model/abstracteffectitem.hpp
M  +19   -0    src/effects/effectstack/model/effectitemmodel.cpp
M  +1    -0    src/effects/effectstack/model/effectitemmodel.hpp
M  +26   -5    src/mainwindow.cpp
M  +2    -1    src/mainwindow.h
M  +44   -28   src/project/projectmanager.cpp
M  +2    -2    src/project/projectmanager.h
M  +1    -1    src/timeline2/view/timelinecontroller.cpp
M  +30   -18   src/timeline2/view/timelinetabs.cpp
M  +3    -1    src/timeline2/view/timelinetabs.hpp
M  +2    -2    tests/filetest.cpp
M  +3    -3    tests/modeltest.cpp
M  +9    -9    tests/nestingtest.cpp
M  +4    -4    tests/sequencetest.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/984dec0103b12782dae83e0e292a988db6c23c88