Bug 438964 - MDI Window title bar close button poor contrast
Summary: MDI Window title bar close button poor contrast
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-06-20 19:50 UTC by Kai Uwe Broulik
Modified: 2022-02-21 19:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.24.2
Sentry Crash Report:


Attachments
White title bar button (10.06 KB, image/png)
2021-06-20 19:50 UTC, Kai Uwe Broulik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2021-06-20 19:50:22 UTC
Created attachment 139554 [details]
White title bar button

SUMMARY
The title bar of MDI windows (windows inside windows) is white on gray. It should probably be red like the normal title bar button.

STEPS TO REPRODUCE
1. Create a new form in Qt designer

OBSERVED RESULT
Gray title bar with white close button for the form

EXPECTED RESULT
Gray title bar with red close button for the form

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: git master as of 2021-06-17
Qt Version: 5.15.3
Comment 1 Nate Graham 2021-07-28 20:38:21 UTC

*** This bug has been marked as a duplicate of bug 440231 ***
Comment 2 Kai Uwe Broulik 2021-07-28 20:40:09 UTC
This isn't about hover though
Comment 3 Bug Janitor Service 2022-02-16 18:16:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/185
Comment 4 Nate Graham 2022-02-21 19:47:15 UTC
Git commit 6d3c04d729ae4665c14f983fa3b98361b164d234 by Nate Graham, on behalf of Janet Blackquill.
Committed on 21/02/2022 at 19:47.
Pushed by ngraham into branch 'master'.

kstyle: make MDI title buttons legible

Don't blend window background (default white) with selected text color
(also white), as this results in unreadable combinations. Instead, blend
it with the normal color.
FIXED-IN: 5.24.2

M  +1    -1    kstyle/breezestyle.cpp

https://invent.kde.org/plasma/breeze/commit/6d3c04d729ae4665c14f983fa3b98361b164d234
Comment 5 Nate Graham 2022-02-21 19:47:47 UTC
Git commit 594a5157e7cafe9627d79686d5e09ee6a0357d93 by Nate Graham, on behalf of Janet Blackquill.
Committed on 21/02/2022 at 19:47.
Pushed by ngraham into branch 'Plasma/5.24'.

kstyle: make MDI title buttons legible

Don't blend window background (default white) with selected text color
(also white), as this results in unreadable combinations. Instead, blend
it with the normal color.
FIXED-IN: 5.24.2


(cherry picked from commit 6d3c04d729ae4665c14f983fa3b98361b164d234)

M  +1    -1    kstyle/breezestyle.cpp

https://invent.kde.org/plasma/breeze/commit/594a5157e7cafe9627d79686d5e09ee6a0357d93