Bug 438931 - In split editing view, the "Delete split" button is missing
Summary: In split editing view, the "Delete split" button is missing
Status: RESOLVED NOT A BUG
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 5.1.1
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-19 23:14 UTC by Dawid Wróbel
Modified: 2021-06-30 05:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
The differences in dialog between macOS and Linux (308.90 KB, image/png)
2021-06-19 23:44 UTC, Dawid Wróbel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Wróbel 2021-06-19 23:14:17 UTC
SUMMARY
You can delete a split if you press a Del button on the keyboard, but a corresponding UI button is missing.

STEPS TO REPRODUCE
1. Edit a split

OBSERVED RESULT
There's no "Delete split" button

EXPECTED RESULT
"Delete split" button should be present.
Comment 1 Dawid Wróbel 2021-06-19 23:44:01 UTC
Created attachment 139529 [details]
The differences in dialog between macOS and Linux

Both macOS and Linux have Delete button missing, and interestingly have different placement of the buttons (probably a Qt applying platform-specific UI/UX rules).
Comment 2 Dawid Wróbel 2021-06-19 23:46:14 UTC
The "Delete" (Clear) button is present in the code and the .ui form file, but otherwise note visible in the app. Same with "New" button.
Comment 3 Dawid Wróbel 2021-06-20 00:04:38 UTC
OK, I see that we have ksplittransactiondlg.ui and splitdialog.ui, both of which look very similar. Why do we need both?
Comment 4 Jack 2021-06-20 00:19:05 UTC
On Linux, in the Split Dialog I see both a "Clear All" button and a "Clear Zero" button.  The latter is perhaps badly worded, but it does remove the selected split.  Perhaps the label could be changed from "Clear Zero" to "Clear Split"?
Comment 5 Dawid Wróbel 2021-06-20 00:38:42 UTC
Jack,

"Clear Zero" clears those that have amount equal to 0. But what is missing is a button that will allow to delete a single row – which is available under right click menu.
Comment 6 Dawid Wróbel 2021-06-20 00:43:01 UTC
For the record, that button is missing only in 5.1, which uses ksplittransactiondlg.ui. Master apparently uses splitdialog.ui, and that actually already has a "Delete" (single split) button.
Comment 7 Thomas Baumgart 2021-06-20 05:31:20 UTC
ksplittransactiondlg.ui will eventually be removed (it contains the code based on the old register). splitdialog.ui is used by the new editor code. The context menu contains the delete function for the selected split(s).

I am not sure if we should worry too much about it here since we want to get rid of this anyway. I would want to know how that button arrangement difference looks like in master, though.