Bug 438920 - Consider a more compact display style for licenses in application details form
Summary: Consider a more compact display style for licenses in application details form
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-19 15:47 UTC by Patrick Silva
Modified: 2022-02-04 16:03 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.25
Sentry Crash Report:


Attachments
screenshot (173.11 KB, image/png)
2021-06-19 15:47 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-06-19 15:47:16 UTC
Created attachment 139521 [details]
screenshot

Title says it all. Please see the attached screenshot.
Chromium and Darktable are examples of affected apps.

EXPECTED RESULT
Application details should always be horizontally centered in the description page

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Patrick Silva 2021-06-19 15:56:13 UTC
I have noticed this bug only with flatpaks so far.
Comment 2 Aleix Pol 2021-07-06 14:46:09 UTC
This is because there's so many licences that the layout goes into compact mode. You'll see that if you maximise the window everything will get back in place.

We could discuss whether we should display licences in a different way maybe.
Comment 3 Nate Graham 2021-07-30 16:38:59 UTC
Yes, this is technically intentional because the FormLayout switches to a left-aligned appearance automatically when there is not enough horizontal space to show everything without eliding text. We reasoned that it would be better to change the layout to keep everything visible than to elide text when there is still space available.

However I agree with Aleix that we could maybe display licenses in a better way. Perhaps a vertical list rather than a horizontal list.
Comment 4 Bug Janitor Service 2022-01-31 01:06:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/246
Comment 5 Nate Graham 2022-02-04 16:03:42 UTC
Git commit 862a1f5a7762bdb681567556df577555718889cb by Nate Graham.
Committed on 04/02/2022 at 02:49.
Pushed by ngraham into branch 'master'.

Overhaul app page

With VDG guidance and mockups, this commit aims to increase the
aesthetic qualities and usefulness of the Application page in the
following ways:

- Move all the metadata from their rather hidden location on the bottom
  of the page to much higher up on the page in a new layout
- Add a defined header area that contains entirely informational
  metadata and screenshots
- Make all the actionable metadata (e.g. "read documentation," "visit
  homepage," "report bug") into buttons
- Improve the license display by only showing the first two when there
  are a lot, with a "show more" button to see them all
- Make the main content area centered rather than left-aligned when the
  page is wide enough to have the content area's maximum width limited
Related: bug 447403
FIXED-IN: 5.25

M  +429  -189  discover/qml/ApplicationPage.qml
M  +1    -1    discover/qml/ApplicationScreenshots.qml
M  +1    -1    libdiscover/resources/AbstractResource.cpp

https://invent.kde.org/plasma/discover/commit/862a1f5a7762bdb681567556df577555718889cb