Bug 438916 - Some tooltips show random numbers
Summary: Some tooltips show random numbers
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-19 15:32 UTC by Patrick Silva
Modified: 2021-08-02 14:28 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22.5
Sentry Crash Report:


Attachments
screen recording (573.41 KB, video/webm)
2021-06-19 15:32 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-06-19 15:32:14 UTC
Created attachment 139519 [details]
screen recording

Title says it all. Please watch the attached screen recording.


EXPECTED RESULT
all tooltips should show the correct information

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.3
Graphics Platform: X11
Comment 1 Felipe Kinoshita 2021-06-19 20:28:03 UTC
Can confirm.
Comment 2 Kishore Gopalakrishnan 2021-06-20 06:56:50 UTC
Git bisect says the bug was introduced by the following commit. Reverting this commit fixes the issue.

7ecb9a262c612be291e91ef5172142f4091af282 is the first bad commit
commit 7ecb9a262c612be291e91ef5172142f4091af282
Author: Carl Schwan <carl@carlschwan.eu>
Date:   Fri May 28 01:48:01 2021 +0200

    Multiple minors cleanup in DiscoverWindow
    
    * Use more StandardKey instead of strings for shortcuts
    * Don't change Kirigami default behavior for activating the mobile
    interface
    * Don't use a loader for the ContextDrawer. It is already only enabled
    on mobile.

 discover/qml/DiscoverWindow.qml | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
Comment 3 Aleix Pol 2021-07-06 14:42:32 UTC
Git commit 979fa085dedb5a2b547e8d8f32fd2fdcf8c817cc by Aleix Pol.
Committed on 06/07/2021 at 14:41.
Pushed by apol into branch 'master'.

Address the keyboard shortcut tooltip

M  +3    -3    discover/qml/ActionListItem.qml

https://invent.kde.org/plasma/discover/commit/979fa085dedb5a2b547e8d8f32fd2fdcf8c817cc
Comment 4 Aleix Pol 2021-07-06 14:42:55 UTC
Git commit a7fcb85803b151f5e36c399453fa0bc739853911 by Aleix Pol Gonzalez, on behalf of Aleix Pol.
Committed on 06/07/2021 at 14:42.
Pushed by apol into branch 'Plasma/5.22'.

Address the keyboard shortcut tooltip


(cherry picked from commit 979fa085dedb5a2b547e8d8f32fd2fdcf8c817cc)

M  +3    -3    discover/qml/ActionListItem.qml

https://invent.kde.org/plasma/discover/commit/a7fcb85803b151f5e36c399453fa0bc739853911
Comment 5 Patrick Silva 2021-07-09 13:23:09 UTC
This bug persists with "Check for updates" button on neon unstable.
Comment 6 Nate Graham 2021-08-02 14:13:49 UTC
Can reproduce that.
Comment 7 Nate Graham 2021-08-02 14:26:50 UTC
Git commit 86e0ceaf4b59b033bee33208ee2f0ca3f58b03a2 by Nate Graham.
Committed on 02/08/2021 at 14:25.
Pushed by ngraham into branch 'master'.

Show actual shortcut for Refresh action's tooltip
FIXED-IN: 5.22.5

M  +7    -2    discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/commit/86e0ceaf4b59b033bee33208ee2f0ca3f58b03a2
Comment 8 Nate Graham 2021-08-02 14:28:22 UTC
Git commit 4c753725aaaa177601231593543a6c3a9119ec62 by Nate Graham.
Committed on 02/08/2021 at 14:27.
Pushed by ngraham into branch 'Plasma/5.22'.

Show actual shortcut for Refresh action's tooltip
FIXED-IN: 5.22.5
(cherry picked from commit 86e0ceaf4b59b033bee33208ee2f0ca3f58b03a2)

M  +7    -2    discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/commit/4c753725aaaa177601231593543a6c3a9119ec62