Bug 438769 - Move keyframes to negative position crash krita
Summary: Move keyframes to negative position crash krita
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Other Linux
: NOR crash
Target Milestone: ---
Assignee: Eoin O'Neill
URL:
Keywords: release_blocker
Depends on:
Blocks:
 
Reported: 2021-06-16 20:11 UTC by grum999
Modified: 2021-06-19 15:25 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/krita/commit/c60a2d00290e3ee297ff93a8e1bb9aca90dfad88
Version Fixed In:
Sentry Crash Report:

Attachments
Example of crash (425.62 KB, video/webm)
2021-06-16 20:11 UTC, grum999 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description grum999 2021-06-16 20:11:11 UTC 
Created attachment 139413 [details]
Example of crash

SUMMARY



STEPS TO REPRODUCE
1. Create an animation 
2. Select keyframes 
3. Move it


OBSERVED RESULT
When moved to:
   - positive position=OK
   - negative position=Crash (segmentation fault)


EXPECTED RESULT
Do not crash :) 

In this case a negative position must be forced to be at frame 0


SOFTWARE/OS VERSIONS
krita-5.0.0-prealpha-949e869-x86_64.appimage
Comment 1 grum999 2021-06-16 20:12:11 UTC 
When crashed, this message is printed in terminal:

ASSERT (krita): "time >= 0" in file /home/appimage/workspace/Krita_Nightly_Appimage_Build/krita/libs/image/kis_keyframe_channel.cpp, line 97
Comment 2 Emmet O'Neill 2021-06-17 01:29:34 UTC 
Ahh, that's a funny one. :)

Good find!
Comment 3 Emmet O'Neill 2021-06-17 01:30:25 UTC 
(Also I want to thank you for sharing the videos. It's super helpful.)
Comment 4 grum999 2021-06-17 11:23:56 UTC 
(In reply to Emmet O'Neill from comment #3)
> (Also I want to thank you for sharing the videos. It's super helpful.)

Writing process to reproduce a bug is sometimes difficult.
Videos are an easy way to provide an explanation; even if i forgot something in description, you can literally see what is made, in which condition ;-)



Grum999
Comment 5 Eoin O'Neill 2021-06-18 01:50:20 UTC 
Git commit c60a2d00290e3ee297ff93a8e1bb9aca90dfad88 by Eoin O'Neill.
Committed on 18/06/2021 at 01:49.
Pushed by eoinoneill into branch 'master'.

KisAnimTimelineFrames: Moving keys no longer allows for movement to negative values.

M  +15   -1    plugins/dockers/animation/KisAnimTimelineFramesModel.cpp

https://invent.kde.org/graphics/krita/commit/c60a2d00290e3ee297ff93a8e1bb9aca90dfad88
Comment 6 grum999 2021-06-19 15:25:54 UTC 
(In reply to Eoin O'Neill from comment #5)
> Git commit c60a2d00290e3ee297ff93a8e1bb9aca90dfad88 by Eoin O'Neill.
> Committed on 18/06/2021 at 01:49.
I can confirm problem is fixed :) 

Grum999