Created attachment 139410 [details] example of problem SUMMARY Not sure if related to https://bugs.kde.org/show_bug.cgi?id=438341 So I prefer to create a new bug STEPS TO REPRODUCE 1. Create a paint layer with a rectangle 2. Add a transform mask on paint layer 3. Create some keyframes in animation curves 4. Start to navigate between keyframe 5. Click on "insert keyframe" (not sure about button name) OBSERVED RESULT (A) A new keyframe is created, but with wrong value (not related to zoom here!) (B) To undo action, we have to execute UNDO action (CTRL+Z) 9 times (one per transform mask property) EXPECTED RESULT (A) When inserting a new keyframe, properties have to be properly interpolated (B) Only one CTRL+Z should be needed to undo action SOFTWARE/OS VERSIONS krita-5.0.0-prealpha-949e869-x86_64.appimage
Yeah, that should be grouped into a single undo command for sure. Thanks!
Git commit ec7d311c7e51542b694654e47514ed007f609993 by Eoin O'Neill. Committed on 17/06/2021 at 01:23. Pushed by eoinoneill into branch 'master'. KisAnimCurvesDocker: Fix add keyframe / remove keyframe buttons undo stack. Originally, they were adding all keyframes as their own undo operation, causing undo spam. They now correctly group all keyframe additions and removals to one undo object. M +47 -43 plugins/dockers/animation/KisAnimCurvesDocker.cpp M +6 -1 plugins/dockers/animation/KisAnimCurvesDocker.h https://invent.kde.org/graphics/krita/commit/ec7d311c7e51542b694654e47514ed007f609993
I'll try to test it tonight... But commit is only for CTRL+Z? Or it takes in account case (A) too? (I tried to look in code but... I'm not sure ^_^") Grum999
(In reply to Eoin O'Neill from comment #2) > Git commit ec7d311c7e51542b694654e47514ed007f609993 by Eoin O'Neill. > Committed on 17/06/2021 at 01:23. > Pushed by eoinoneill into branch 'master'. I confirm problem (B) about CTRL+Z is fixed I'll create a new dedicated bug about problem (A) Grum999