Created attachment 139320 [details] example of inconsistent looking of keyboard layout switcher icon The icon of keyboard layout switcher in the tray is misaligned and it has inconsistent looking regarding of other tray icons. It has happened after recent commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/be6e36e548fba3d6dba426891a19e319107616e7. The attachment shows example of this behavior.
Created attachment 139321 [details] example of inconsistent looking of keyboard layout switcher icon (us layout)
Andrey, can you investigate and correct this?
We will check and revert in worst case. Currently I have no idea what's wrong, but AFAIK we didn't test on HiDPI so my wild guess it might be related. Please confirm.
I think it will be better to revert this commit, if it's causing such weird positioning on some systems. Still using toUpperCase() for language code is good alternative, IMHO. It won't have vertical positioning issues at all.
We are about to revert this, but have alternative solution. Still, the roots of the problem is not clear, so please help us reproduce it: is you display HiDPI, does it happen on new user with default settings, panel size etc.? Thanks.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/504
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/505
Git commit 3654bb5b875cd090f943bcf6bd7d453ca25cd2df by Andrey Butirsky. Committed on 16/06/2021 at 18:58. Pushed by butirsky into branch 'master'. Revert "[keyboard layout applet] Make keyboard layout label vertically centered" This reverts commit be6e36e548fba3d6dba426891a19e319107616e7 The patch didn't work when system tray icons are not scaled and on some non-standard panel sizes. M +0 -8 applets/keyboardlayout/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/commit/3654bb5b875cd090f943bcf6bd7d453ca25cd2df
I suppose you didn't have "resize icons by panel height" tick set in systray settings?
(In reply to Andrey from comment #9) > I suppose you didn't have "resize icons by panel height" tick set in systray > settings? That setting is ticked in systray settings, but it doesn't have effect on keyboard layout switcher indicator.
(In reply to ChronosX88 from comment #10) > (In reply to Andrey from comment #9) > > I suppose you didn't have "resize icons by panel height" tick set in systray > > settings? > > That setting is ticked in systray settings, but it doesn't have effect on > keyboard layout switcher indicator. By "doesn't have effect" I mean indicator is still centered incorrectly.
So can you make it look good somehow then? Maybe you have set another font or resized panel that is why it's always broken for you now. AFAIK, on our side it looks good with that tick set.
(In reply to Andrey from comment #12) > So can you make it look good somehow then? > Maybe you have set another font or resized panel that is why it's always > broken for you now. > AFAIK, on our side it looks good with that tick set. No, I tried everything, it is still doesn't look good.
(In reply to Andrey from comment #5) > We are about to revert this, but have alternative solution. > Still, the roots of the problem is not clear, so please help us reproduce it: > is you display HiDPI, does it happen on new user with default settings, > panel size etc.? > Thanks. Yes, I have HiDPI displays (both - laptop and external screen).
Could you check if you can center the label with this patch? We can't test on HiDPI currently.. https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/502