Bug 438630 - Adding zero variants of arm64 v8.2 FCMEQ, FCMGE, FCMGT, FCMLE and FCMLT instructions
Summary: Adding zero variants of arm64 v8.2 FCMEQ, FCMGE, FCMGT, FCMLE and FCMLT instr...
Status: CLOSED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: ahashmi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-14 16:47 UTC by ahashmi
Modified: 2021-06-29 16:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Adds zero variants of arm64 v8.2 FCMEQ, FCMGE, FCMGT, FCMLE and FCMLT instructions (256.62 KB, text/plain)
2021-06-16 11:07 UTC, ahashmi 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description ahashmi 2021-06-14 16:47:40 UTC 
This patch is part of work adding arm64 v8.2 support as summarised in container bug https://bugs.kde.org/show_bug.cgi?id=428016

The register variant of this patch is https://bugs.kde.org/show_bug.cgi?id=438038
Comment 1 ahashmi 2021-06-16 11:07:35 UTC 
Created attachment 139381 [details]
Adds zero variants of arm64 v8.2 FCMEQ, FCMGE, FCMGT, FCMLE and FCMLT instructions

NOTE: This patch is for the compare-with-zero variants of instructions currently at review in https://bugs.kde.org/show_bug.cgi?id=438038 and is based on a branch which includes those changes.
Comment 2 Julian Seward 2021-06-17 12:43:16 UTC 
(In reply to ahashmi from comment #1)
> Created attachment 139381 [details]
> Adds zero variants of arm64 v8.2 FCMEQ, FCMGE, FCMGT, FCMLE and FCMLT
> instructions

This seems fine; r+ to land.  Has no assertions on the decode-fail paths,
which is as desired.
Comment 3 ahashmi 2021-06-29 16:23:52 UTC 
Landed 393732dda164c1cc0fc511eadc0b8f06008ade4f