Bug 438589 - KStars is forcing the Fusion theme
Summary: KStars is forcing the Fusion theme
Status: VERIFIED FIXED
Alias: None
Product: kstars
Classification: Applications
Component: general (other bugs)
Version First Reported In: 3.5.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jasem Mutlaq
URL:
Keywords:
: 432131 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-06-14 02:24 UTC by Nate Graham
Modified: 2021-06-25 12:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 3.5.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-06-14 02:24:39 UTC
I use the Breeze widget theme systemwide and want this to be respected in my apps--especially in my KDE apps. :) It would be nice if KStars used the system widget theme by default instead of Fusion.

If the reason why you're doing this is to be able to have custom color schemes, this is possible in another way without forcing the use of a specific widget theme. You might look to see how Kate or Konsole handle it, for example.

Super amazing software, BTW.
Comment 1 Jasem Mutlaq 2021-06-14 08:33:43 UTC
Hi Nate, thank you for the feedback. I don't recall the original reason for forcing Fusion. Remember this has to work consistently not only across Mac/Linux/Windows, but across the different Linux distros as well. I just removed the line that fusion line and was able to change the color schemes just fine, so it must have been another reason.

Need to test again across different OSes and distros to ensure there are no side-effects.
Comment 2 Nate Graham 2021-06-14 13:18:03 UTC
Understood. Perhaps it could inherit the system style at least for Plasma-based or Linux-based environments, if set?
Comment 3 Jasem Mutlaq 2021-06-14 21:31:28 UTC
Right that could work... how can I tell if we are on a plasma based system though? is there an easy way to check?
Comment 4 Nate Graham 2021-06-14 21:41:13 UTC
Check for XDG_CURRENT_DESKTOP=KDE using qgetenv; that's the freedesktop-supported way.
Comment 5 Jasem Mutlaq 2021-06-15 20:30:03 UTC
Git commit 14259e3ca91e519764393f33075c161806c3c41e by Jasem Mutlaq.
Committed on 15/06/2021 at 20:29.
Pushed by mutlaqja into branch 'master'.

Only force fusion on non-KDE desktops.
FIXED-IN:3.5.4

M  +34   -28   kstars/auxiliary/thememanager.cpp

https://invent.kde.org/education/kstars/commit/14259e3ca91e519764393f33075c161806c3c41e
Comment 6 Nate Graham 2021-06-15 20:51:48 UTC
Thanks!
Comment 7 Nate Graham 2021-06-15 21:24:59 UTC
Verified, thanks! Looks a thousand times better with Breeze. :)
Comment 8 Nate Graham 2021-06-25 12:20:19 UTC
*** Bug 432131 has been marked as a duplicate of this bug. ***