Bug 438559 - Domain name quickgit.kde.org does not exist
Summary: Domain name quickgit.kde.org does not exist
Status: CLOSED WORKSFORME
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.22.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL: https://quickgit.kde.org/?p=discover.git
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-13 15:59 UTC by Christopher Yeleighton
Modified: 2021-07-07 18:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Yeleighton 2021-06-13 15:59:44 UTC
SUMMARY
The home page for Discover does not exist.

STEPS TO REPRODUCE
1. Tell Discover to show Discover!
2. Tell Discover to open the hyperlink!
3. 

OBSERVED RESULT
quickgit.kde.org: DNS_PROBE_FINISHED_NXDOMAIN

EXPECTED RESULT
Discover

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.12.9-1-default
(available in About System)
KDE Plasma Version: 5.22.0
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Christopher Yeleighton 2021-06-13 16:46:31 UTC
The wrong URL is taken from RPM.  Discover should specify it explicitly in metainfo.  Here is a good one: <URL: https://apps.kde.org/discover/ >.
Comment 2 Nate Graham 2021-06-15 20:16:01 UTC
Discover's AppStream data is clean, and shows https://invent.kde.org/plasma/discover. So this old URL must be coming from your distro's out of date packaging. I would report this to them.
Comment 3 Christopher Yeleighton 2021-06-15 20:19:18 UTC
(In reply to Nate Graham from comment #2)
> Discover's AppStream data is clean, and shows
> https://invent.kde.org/plasma/discover. So this old URL must be coming from
> your distro's out of date packaging. I would report this to them.

So I have.  But Discover's AppStream data is also clean of mentioning some home page form Discover and that is bad.  We should not rely on RPM to provide the correct URL, we should provide one ourselves.
Comment 4 Christopher Yeleighton 2021-06-15 20:47:51 UTC
See also <URL: https://invent.kde.org/plasma/discover/-/merge_requests/136 >.  Being a newbie, I cannot tell whether it is right or wrong; I am currently trying to build this thing to see whether anything I did is totally off.  I need the right builder image though and it may take a lot of steps (and failures) to get it right.
Comment 5 Nate Graham 2021-06-15 20:53:59 UTC
So what we do rely on is the metainfo generator parsing the KAboutData as a source of truth, which it does do. :) The alternative is setting it manually which will lead to conflicting sources of truth and that's just the beginning of a maintenance headache.

Please report this to your distro.
Comment 6 Christopher Yeleighton 2021-06-15 20:57:52 UTC
The ultimate source of truth regarding what the URL is is us, not the downstream packager.  As I said, I have reported it to the distro—but where is the distro packager supposed to get the right URL from if not from our metainfo?
Comment 7 Aleix Pol 2021-07-06 13:59:09 UTC
I have no idea what you are talking about. Discover doesn't list quickgit.kde.org. Are you maybe running an old version of Discover?

In the end it's true, at some point quickgit.kde.org was a thing. Not anymore.
Comment 8 Christopher Yeleighton 2021-07-07 18:12:32 UTC
(In reply to Aleix Pol from comment #7)
> I have no idea what you are talking about. Discover doesn't list
> quickgit.kde.org. Are you maybe running an old version of Discover?
> 
> In the end it's true, at some point quickgit.kde.org was a thing. Not
> anymore.

Discover does not list any home page for itself, that is why distribution packagers get it wrong.