Bug 438538 - Krita is doing some calculations on hidden layers
Summary: Krita is doing some calculations on hidden layers
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Emmet O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-13 08:13 UTC by grum999
Modified: 2021-07-29 23:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Example file with some layers and animation already ready for testing (637.61 KB, application/x-krita)
2021-06-13 08:13 UTC, grum999
Details

Note You need to log in before you can comment on or make changes to this bug.
Description grum999 2021-06-13 08:13:48 UTC
Created attachment 139277 [details]
Example file with some layers and animation already ready for testing

SUMMARY

When rendering an animation, it seems Krita is doing useless calculation on hidden layers.


STEPS TO REPRODUCE
1. Create a document with the following layers

[root]
    +-- Group1 (hidden)
    |    +-- Paint layer 1
    |         +-- Transform mask 1 (==> apply an animation curve to transform mask to create an animation)
    +-- Group2
         +-- Paint layer 2
              +-- Transform mask 2 (==> apply an animation curve to transform mask to create an animation)

2. Render animation


OBSERVED RESULT
We can see the animation icon on "Transform mask 1" and "Transform mask 2" are blinking (ie: there's some calculation activity, the progress bat is displayed on layer )

=> Hide "Transform Mask 1" or "Paint Layer 1": no more calculation activity is visible

Also, if Group1 is merged or deleted, rendering is faster



EXPECTED RESULT
When layer is hidden, all children and sub-children should be considered as hidden and then, no calculation should be applied for these layers.


NOTES:
- Not sure if it only happens for animated transformation masks or if it occurs for all layers types (animated, or not)



SOFTWARE/OS VERSIONS
krita-5.0.0-prealpha-c25d2e1-x86_64.appimage
Comment 2 Ahab Greybeard 2021-06-14 08:22:15 UTC
I can confirm this with the Jun 11 5.0.0-prealpha (git c25d2e1) appimage on Debian 10.

Selectively turning off the visibilty of the animated transform masks and the filter layers, both individually and in combination, has a proportional effect on the cache regeneration time for a newly opened file, even though their parent group is hidden.
These layers/masks also display activity on the 'activity progress bar' of the layer in the layers docker.
Comment 4 Emmet O'Neill 2021-06-17 01:41:36 UTC
(May be related to this https://bugs.kde.org/show_bug.cgi?id=438768
Animation curves - transform mask calculation activity even if cache has been rendered)
Comment 5 Eoin O'Neill 2021-07-07 20:57:52 UTC
Is this resolved as of commit b347ab13a326fc571c6ff6e1f51f515c3e5d5a78 ?

Animated transform masks should no longer recalculate in general, so I would presume that this issue is either not around anymore or has to be rethought...
Comment 6 grum999 2021-07-09 18:05:18 UTC
(In reply to Eoin O'Neill from comment #5)
> Is this resolved as of commit b347ab13a326fc571c6ff6e1f51f515c3e5d5a78 ?
> 
> Animated transform masks should no longer recalculate in general, so I would
> presume that this issue is either not around anymore or has to be
> rethought...

@Dmitry Kazakov fixed it here:
https://krita-artists.org/t/animation-frame-rendering-clones-limit-render-in-failure/25029/25?u=grum999

But I'm not able to tell which commit it was :) 


The only thin I can tell is the problem has been fixed


Grum999
Comment 7 Bug Janitor Service 2021-07-10 04:33:44 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.