Bug 438504 - Label of combobox is cut off in Virtual Desktops KCM
Summary: Label of combobox is cut off in Virtual Desktops KCM
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwinvirtualdesktops (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-12 12:28 UTC by Patrick Silva
Modified: 2021-06-15 23:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22.2


Attachments
screenshot (119.15 KB, image/png)
2021-06-12 12:28 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-06-12 12:28:18 UTC
Created attachment 139252 [details]
screenshot

STEPS TO REPRODUCE
1. open Virtual Desktops KCM
2. 
3. 

OBSERVED RESULT
please see the attached screenshots

EXPECTED RESULT
combobox label should be entirely readable

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 1 Nate Graham 2021-06-15 23:24:07 UTC
Looks like it's caused by a local workaround for an issue in Kirigami.FormLayout that has long since been fixed. Let's just remove it.
Comment 2 Nate Graham 2021-06-15 23:27:31 UTC
Git commit 77affd325923742e611c4a0e2c0c124fc9e6a7f5 by Nate Graham.
Committed on 15/06/2021 at 23:27.
Pushed by ngraham into branch 'master'.

[kcmkwin/kwindesktop] Drop local back for Formlayout label width

This hack was added in the past to prevent the combobox from being
pushed out of view when the label next to it was very long, as it can be
in certain languages. However it had the effect of making the label get
elided in *all* languages, and also the issue it was working around is
no longer present; even with very long text, the combobox no longer gets
pushed out of view, and instead the formlayout first switches to mobile
view and then elides the Label, exactly as intended. So we can safely
remove the hack.
FIXED-IN: 5.22.2

M  +0    -2    src/kcmkwin/kwindesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/77affd325923742e611c4a0e2c0c124fc9e6a7f5
Comment 3 Nate Graham 2021-06-15 23:27:53 UTC
Git commit c6d2f4ced230aece621715f046f0a501b5e9884f by Nate Graham.
Committed on 15/06/2021 at 23:27.
Pushed by ngraham into branch 'Plasma/5.22'.

[kcmkwin/kwindesktop] Drop local back for Formlayout label width

This hack was added in the past to prevent the combobox from being
pushed out of view when the label next to it was very long, as it can be
in certain languages. However it had the effect of making the label get
elided in *all* languages, and also the issue it was working around is
no longer present; even with very long text, the combobox no longer gets
pushed out of view, and instead the formlayout first switches to mobile
view and then elides the Label, exactly as intended. So we can safely
remove the hack.
FIXED-IN: 5.22.2
(cherry picked from commit 77affd325923742e611c4a0e2c0c124fc9e6a7f5)

M  +0    -2    src/kcmkwin/kwindesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/kwin/commit/c6d2f4ced230aece621715f046f0a501b5e9884f