Bug 438400 - [Requests] Make it default to use Stop Gradient instead of Segment Gradient
Summary: [Requests] Make it default to use Stop Gradient instead of Segment Gradient
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (other bugs)
Version First Reported In: nightly build (please specify the git hash!)
Platform: Compiled Sources All
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-10 11:42 UTC by acc4commissions
Modified: 2021-07-21 10:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2021-06-10 11:42:46 UTC
SUMMARY
5.0 prealpha

Since it's more simple and basic, and it's how the most other applications do their gradients according to the manual, I think it's better to let the most users use it by default. 

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: Win10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Deif Lou 2021-06-10 12:06:08 UTC
The only thing I can imagine you are refering to is that the gradient presets are segment gradients and you want them to be stop gradients... maybe? I don't know, you'll have to explain better.
Comment 2 acc4commissions 2021-06-10 12:10:29 UTC
Oh, I see how it works now. I thought there was a default setting of Gradient since it was set to Segment Gradient every time I open the gradient filter window. But that was because the gradient preset(Foreground to Background) uses that method, not Krita. 

Changing it to resolved.
Comment 3 acc4commissions 2021-06-10 12:13:26 UTC
Could you make the preset loaded in Gradient filter follows what you selected atm in fill gradient in Toolbar then?
Comment 4 Deif Lou 2021-06-10 12:19:32 UTC
I can look into that.
Comment 5 acc4commissions 2021-06-10 12:28:41 UTC
(In reply to acc4commissions from comment #3)
> Could you make the preset loaded in Gradient filter follows what you
> selected atm in fill gradient in Toolbar then?

But I don't think this is any urgent tho. This could be in the last of the last of the priority list.
Comment 6 acc4commissions 2021-06-11 12:47:36 UTC
(In reply to acc4commissions from comment #3)
> Could you make the preset loaded in Gradient filter follows what you
> selected atm in fill gradient in Toolbar then?

It was just a thought and if making this possible complicates the code or make the structure inconsistant or does anything of that sort, I'm find with not having it at all.
Comment 7 acc4commissions 2021-06-11 12:48:35 UTC
> It was just a thought and if making this possible complicates the code or
> make the structure inconsistant or does anything of that sort, I'm find with
> not having it at all.

*find -> fine
Comment 8 Deif Lou 2021-06-11 13:54:26 UTC
I already made a patch: https://invent.kde.org/graphics/krita/-/merge_requests/903
* When opening for the first time the fill layer or filter it selects the currently active global gradient.
* Once you close the dialog the gradient in it is stored and loaded when you reopen it, it won't reload the global gradient.
* If you change the global gradient it doesn't affect already created fill layers or gradient map filters.
Comment 9 Dmitry Kazakov 2021-06-13 06:13:23 UTC
Git commit 4b90f2b42d4bc9108f86a7019f69b29f1ae0085e by Dmitry Kazakov, on behalf of Deif Lou.
Committed on 13/06/2021 at 06:10.
Pushed by dkazakov into branch 'master'.

Make gradient fill layer and gradient map default to the currently selected global gradient

M  +11   -1    plugins/filters/gradientmap/KisGradientMapFilterConfigWidget.cpp
M  +3    -3    plugins/filters/gradientmap/KisGradientMapFilterConfiguration.cpp
M  +1    -1    plugins/filters/gradientmap/KisGradientMapFilterConfiguration.h
M  +11   -1    plugins/generators/gradient/KisGradientGeneratorConfigWidget.cpp
M  +3    -3    plugins/generators/gradient/KisGradientGeneratorConfiguration.cpp
M  +1    -1    plugins/generators/gradient/KisGradientGeneratorConfiguration.h

https://invent.kde.org/graphics/krita/commit/4b90f2b42d4bc9108f86a7019f69b29f1ae0085e
Comment 10 acc4commissions 2021-07-21 10:10:25 UTC
tbh I bit regret suggesting this since it was a very tiny issue. I hope it won't cause maintenance problems in the future.