Bug 438366 - Notifications use the application theme's link colour
Summary: Notifications use the application theme's link colour
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.22.0
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-09 21:15 UTC by Riccardo Robecchi
Modified: 2021-07-22 18:46 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/7c1f57c5d509e3069e344dfa5392a04d690e4618
Version Fixed In: 5.22.4

Attachments
Screenshot of the issue (33.50 KB, image/png)
2021-06-09 21:15 UTC, Riccardo Robecchi 		Details
Breeze Light plasma theme and honeycomb color scheme (2.76 KB, image/png)
2021-06-10 06:51 UTC, David Redondo 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Riccardo Robecchi 2021-06-09 21:15:15 UTC 
Created attachment 139171 [details]
Screenshot of the issue

SUMMARY
Notifications appear to use the application theme's colour for links, instead of using the Plasma theme's colour. This causes links to be unreadable when a dark Plasma theme and a light application theme are used.

STEPS TO REPRODUCE
1. Set a dark Plasma theme and a light application theme.
2. Copy some files.

OBSERVED RESULT
The link in the notification uses the application theme's colour and is nigh unreadable.

EXPECTED RESULT
The link uses the Plasma theme colour and is readable.

SOFTWARE/OS VERSIONS
Linux: KDE neon
KDE Plasma Version: 5.22.0
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-06-09 21:46:37 UTC 
Which exact Plasma theme are you using? Have you verified that it has a more appropriate link color internally?
Comment 2 David Redondo 2021-06-10 06:51:23 UTC 
Created attachment 139182 [details]
Breeze Light plasma theme and honeycomb color scheme
Comment 3 David Redondo 2021-06-10 07:09:48 UTC 
Related: https://bugreports.qt.io/browse/QTBUG-81463

TextEdit has no way to change link color but text does
Comment 4 Nate Graham 2021-06-10 14:51:02 UTC 
I believe a TextEdit is being used to make the text selectable.
Comment 5 David Redondo 2021-06-10 14:51:31 UTC 
(In reply to Nate Graham from comment #4)
> I believe a TextEdit is being used to make the text selectable.

That's correct :)
Comment 6 Bug Janitor Service 2021-06-20 15:13:22 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/941
Comment 7 Nate Graham 2021-07-22 18:44:47 UTC 
Git commit a3734c74f843e37625783fce14ccbe7e69213d66 by Nate Graham, on behalf of Kai Uwe Broulik.
Committed on 22/07/2021 at 18:37.
Pushed by ngraham into branch 'master'.

[Notifications] Set Plasma linkColor on notification label

There's no API to set `linkColor` on `TextEdit` and it would use the
system link color potentially clashing with the Plasma theme.
FIXED-IN: 5.22.3

M  +6    -1    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a3734c74f843e37625783fce14ccbe7e69213d66
Comment 8 Nate Graham 2021-07-22 18:45:14 UTC 
Git commit 7c1f57c5d509e3069e344dfa5392a04d690e4618 by Nate Graham, on behalf of Kai Uwe Broulik.
Committed on 22/07/2021 at 18:45.
Pushed by ngraham into branch 'Plasma/5.22'.

[Notifications] Set Plasma linkColor on notification label

There's no API to set `linkColor` on `TextEdit` and it would use the
system link color potentially clashing with the Plasma theme.
FIXED-IN: 5.22.3


(cherry picked from commit a3734c74f843e37625783fce14ccbe7e69213d66)

M  +6    -1    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/commit/7c1f57c5d509e3069e344dfa5392a04d690e4618