Bug 438365 - Collapsing the sidebar makes hidden Pages show up as if they weren't hidden
Summary: Collapsing the sidebar makes hidden Pages show up as if they weren't hidden
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.82.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-09 21:09 UTC by Alexander M.
Modified: 2021-06-10 13:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.84


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander M. 2021-06-09 21:09:08 UTC
SUMMARY
If any of the four default Pages (Overview, Processes, Applications, History) are hidden, then if the sidebar is collapsed (Hamburger menu -> Collapse Sidebar) they will become visible and fully functional (i.e. selectable) as if they were not hidden.

Expanding the sidebar again hides them, collapsing it again unhides them, etc.

STEPS TO REPRODUCE
1. Remove one or more of the default Pages.
2. Collapse the sidebar.

OBSERVED RESULT
Removed Pages are visible and selectable.

EXPECTED RESULT
Removed Pages should not be visible and selectable.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.22
KDE Frameworks Version: 5.82
Qt Version: 5.15.2 + the KDE patches
Comment 1 Nate Graham 2021-06-09 23:21:33 UTC
Can confirm, lol
Comment 2 David Redondo 2021-06-10 08:25:12 UTC
We are setting visible: false, points to something in kriigami
Comment 3 Bug Janitor Service 2021-06-10 08:54:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/317
Comment 4 Arjen Hiemstra 2021-06-10 11:12:20 UTC
Git commit 5bb5968420f88294dd43aca57571cbc5e002e910 by Arjen Hiemstra.
Committed on 10/06/2021 at 08:54.
Pushed by ahiemstra into branch 'master'.

Respect an Action's visible property in GlobalDrawer even when collapsed

X || Y with X being true is always true. This means we never evaluate
the visible property when collapsed since the second part is combined as
(!expandible && visible). So instead, first check if visible is true and
only then check collapsed/expandible properties.

M  +1    -1    src/controls/GlobalDrawer.qml

https://invent.kde.org/frameworks/kirigami/commit/5bb5968420f88294dd43aca57571cbc5e002e910